Uploaded image for project: 'Maven Surefire'
  1. Maven Surefire
  2. SUREFIRE-1311

JUnit47 provider should not internally parse JUnit Description

    Details

      Description

      We used regex pattern to parse JUnit Description from string form to (className and methodName) in provider surefire-junit4.
      The provider surefire-junit47 inherited the same principle which is wrong because JUnit 4.6 already has this parser inside and we should call Description.getClassName() and Description.getMethodName().

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-surefire #1650 (See https://builds.apache.org/job/maven-surefire/1650/)
        SUREFIRE-1311 JUnit47 provider should not internally parse JUnit (tibor17: rev d9b577cdc991d09116282d89ca69b5d2768acb0e)

        • (edit) surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/JUnit46StackTraceWriter.java
        • (edit) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/JUnit4RunListener.java
        • (edit) surefire-providers/common-junit48/pom.xml
        • (edit) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/JUnit4StackTraceWriter.java
        • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/NonConcurrentRunListener.java
        • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreRunListener.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-surefire #1650 (See https://builds.apache.org/job/maven-surefire/1650/ ) SUREFIRE-1311 JUnit47 provider should not internally parse JUnit (tibor17: rev d9b577cdc991d09116282d89ca69b5d2768acb0e) (edit) surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/JUnit46StackTraceWriter.java (edit) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/JUnit4RunListener.java (edit) surefire-providers/common-junit48/pom.xml (edit) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/JUnit4StackTraceWriter.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/NonConcurrentRunListener.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreRunListener.java
        Show
        tibor17 Tibor Digana added a comment - https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=d9b577cdc991d09116282d89ca69b5d2768acb0e

          People

          • Assignee:
            tibor17 Tibor Digana
            Reporter:
            tibor17 Tibor Digana
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development