Uploaded image for project: 'Maven Surefire'
  1. Maven Surefire
  2. SUREFIRE-1293

Simplify org.apache.maven.plugin.surefire.report.TestSetRunListener by using the null object pattern

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.20
    • Maven Surefire Plugin

    Description

      The class org.apache.maven.plugin.surefire.report.TestSetRunListener has a lot of checks like this:

      if( field != null )
      {
          // do something with field
      }
      

      This can be simplified by providing fallback implementations for the fields being used by TestSetRunListener.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tibordigana Tibor Digana
            britter Benedikt Ritter
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment