Details

      Description

      with MNG-3507 fixed, adding colors to tests results would improve readability

        Issue Links

          Activity

          Hide
          tibor17 Tibor Digana added a comment -

          This would be cool to have. Some users stated we should use logger instead of std/out.
          I will have a look into this.

          Show
          tibor17 Tibor Digana added a comment - This would be cool to have. Some users stated we should use logger instead of std/out. I will have a look into this.
          Hide
          benno.markiewicz+dev@googlemail.com Benno Markiewicz added a comment -

          Please make it optional and disabled by default. Else you will break external tools like Jenkins/NetBeans, which parse the output of the surefire-plugin. Their regex patterns won't match anymore.

          Show
          benno.markiewicz+dev@googlemail.com Benno Markiewicz added a comment - Please make it optional and disabled by default. Else you will break external tools like Jenkins/NetBeans, which parse the output of the surefire-plugin. Their regex patterns won't match anymore.
          Hide
          tibor17 Tibor Digana added a comment -

          Colors are disabled by mvn -B test; otherwise any other plugin @
          mvn 3.4.0 would be problematic.
          Jenkins does not parse std/out. The tools use target/surefire-reports/.
          We can directly ask the Jenkins team.


          Cheers
          Tibor

          Show
          tibor17 Tibor Digana added a comment - Colors are disabled by mvn -B test ; otherwise any other plugin @ mvn 3.4.0 would be problematic. Jenkins does not parse std/out. The tools use target/surefire-reports/. We can directly ask the Jenkins team. – Cheers Tibor
          Hide
          benno.markiewicz+dev@googlemail.com Benno Markiewicz added a comment -

          Disabling the coloring when running in batch-mode?! That makes sense. Thanks for the feedback!

          Show
          benno.markiewicz+dev@googlemail.com Benno Markiewicz added a comment - Disabling the coloring when running in batch-mode?! That makes sense. Thanks for the feedback!
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Tibor17 opened a pull request:

          https://github.com/apache/maven-surefire/pull/117

          SUREFIRE-1254 add color messages

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Tibor17/maven-surefire SUREFIRE-1254

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/maven-surefire/pull/117.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #117


          commit 87dd0e24c422c6def4f62f3b9c7eb3f1f67d2f18
          Author: Tibor17 <tibor17@lycos.com>
          Date: 2016-09-04T03:32:31Z

          SUREFIRE-1254 add color messages


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/117 SUREFIRE-1254 add color messages You can merge this pull request into a Git repository by running: $ git pull https://github.com/Tibor17/maven-surefire SUREFIRE-1254 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/117.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #117 commit 87dd0e24c422c6def4f62f3b9c7eb3f1f67d2f18 Author: Tibor17 <tibor17@lycos.com> Date: 2016-09-04T03:32:31Z SUREFIRE-1254 add color messages
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77447349

          — Diff: maven-failsafe-plugin/pom.xml —
          @@ -127,6 +127,19 @@
          <excludeTransitive>true</excludeTransitive>
          </configuration>
          </execution>
          + <execution>
          + <id>shared-logging-generated-sources</id>
          — End diff –

          IMHO, a little comment to explain why the source code is rebuilt here could be useful for future maintainers

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77447349 — Diff: maven-failsafe-plugin/pom.xml — @@ -127,6 +127,19 @@ <excludeTransitive>true</excludeTransitive> </configuration> </execution> + <execution> + <id>shared-logging-generated-sources</id> — End diff – IMHO, a little comment to explain why the source code is rebuilt here could be useful for future maintainers
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77447554

          — Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java —
          @@ -0,0 +1,126 @@
          +package org.apache.maven.plugin.surefire.log;
          +
          +/*
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + *
          + * http://www.apache.org/licenses/LICENSE-2.0
          + *
          + * Unless required by applicable law or agreed to in writing,
          + * software distributed under the License is distributed on an
          + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
          + * KIND, either express or implied. See the License for the
          + * specific language governing permissions and limitations
          + * under the License.
          + */
          +
          +import org.apache.maven.plugin.logging.Log;
          +import org.apache.maven.surefire.report.ConsoleLogger;
          +
          +/**
          + * Wrapper logger of miscellaneous (Maven 2.2.1 or 3.1) implementations of

          {@link Log}

          .
          + * Calling

          {@link Log#isInfoEnabled()}

          before

          {@link Log#info(CharSequence)}

          due to Maven 2.2.1.
          + *
          + * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a>
          + * @since 2.19.2
          + * @see ConsoleLogger
          + */
          +public final class PluginConsoleLogger
          + implements ConsoleLogger
          +{
          + private final Log mojoLogger;
          +
          + public PluginConsoleLogger( Log mojoLogger )
          +

          { + this.mojoLogger = mojoLogger; + }

          +
          + public boolean isDebugEnabled()
          +

          { + return mojoLogger.isDebugEnabled(); + }

          +
          + public void debug( String message )
          + {
          + if ( mojoLogger.isDebugEnabled() )
          + {
          + mojoLogger.debug( message );
          — End diff –

          wow, the whole message with debug level color, and more generally each message with level color? this will give too much color.
          I need to see the effective result, but if it's really what I fear, it was not the intent when adding color to Maven output: the intent is just to have a few colored words with general normal message (and nothing else than level with level color)

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77447554 — Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java — @@ -0,0 +1,126 @@ +package org.apache.maven.plugin.surefire.log; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.plugin.logging.Log; +import org.apache.maven.surefire.report.ConsoleLogger; + +/** + * Wrapper logger of miscellaneous (Maven 2.2.1 or 3.1) implementations of {@link Log} . + * Calling {@link Log#isInfoEnabled()} before {@link Log#info(CharSequence)} due to Maven 2.2.1. + * + * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a> + * @since 2.19.2 + * @see ConsoleLogger + */ +public final class PluginConsoleLogger + implements ConsoleLogger +{ + private final Log mojoLogger; + + public PluginConsoleLogger( Log mojoLogger ) + { + this.mojoLogger = mojoLogger; + } + + public boolean isDebugEnabled() + { + return mojoLogger.isDebugEnabled(); + } + + public void debug( String message ) + { + if ( mojoLogger.isDebugEnabled() ) + { + mojoLogger.debug( message ); — End diff – wow, the whole message with debug level color, and more generally each message with level color? this will give too much color. I need to see the effective result, but if it's really what I fear, it was not the intent when adding color to Maven output: the intent is just to have a few colored words with general normal message (and nothing else than level with level color)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77448108

          — Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java —
          @@ -0,0 +1,126 @@
          +package org.apache.maven.plugin.surefire.log;
          +
          +/*
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + *
          + * http://www.apache.org/licenses/LICENSE-2.0
          + *
          + * Unless required by applicable law or agreed to in writing,
          + * software distributed under the License is distributed on an
          + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
          + * KIND, either express or implied. See the License for the
          + * specific language governing permissions and limitations
          + * under the License.
          + */
          +
          +import org.apache.maven.plugin.logging.Log;
          +import org.apache.maven.surefire.report.ConsoleLogger;
          +
          +/**
          + * Wrapper logger of miscellaneous (Maven 2.2.1 or 3.1) implementations of

          {@link Log}

          .
          + * Calling

          {@link Log#isInfoEnabled()}

          before

          {@link Log#info(CharSequence)}

          due to Maven 2.2.1.
          + *
          + * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a>
          + * @since 2.19.2
          + * @see ConsoleLogger
          + */
          +public final class PluginConsoleLogger
          + implements ConsoleLogger
          +{
          + private final Log mojoLogger;
          +
          + public PluginConsoleLogger( Log mojoLogger )
          +

          { + this.mojoLogger = mojoLogger; + }

          +
          + public boolean isDebugEnabled()
          +

          { + return mojoLogger.isDebugEnabled(); + }

          +
          + public void debug( String message )
          + {
          + if ( mojoLogger.isDebugEnabled() )
          + {
          + mojoLogger.debug( message );
          — End diff –

          The purpose is to separate Mojo Logger. I cannot use Mojo in forked JVM. Many times the code uses the same classes and interfaces in in-plugin tests or forked-jvm tests but the same classes are extended and behave different in in these two places however the super type is used eveywhere like polymorphism. The same happened with ConsoleLogger and it has advantage because all can be developed independently and the logger would be same (unlike sometimes we used System.out and Mojo logger or console logger), so now it's only one.
          The important things is that `ConsoleLogger` does not need e.g. `isDebugEnabled` method but `AbstractSurefireMojo` used this for long time, so I decided to use concrete implementation class of `ConsoleLogger` in MOJO but that's the second reason to have this class here
          Unfortunately we use Java 5; otherwise you would see those annotations in methods implemented from interface via `@Override`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77448108 — Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java — @@ -0,0 +1,126 @@ +package org.apache.maven.plugin.surefire.log; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.plugin.logging.Log; +import org.apache.maven.surefire.report.ConsoleLogger; + +/** + * Wrapper logger of miscellaneous (Maven 2.2.1 or 3.1) implementations of {@link Log} . + * Calling {@link Log#isInfoEnabled()} before {@link Log#info(CharSequence)} due to Maven 2.2.1. + * + * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a> + * @since 2.19.2 + * @see ConsoleLogger + */ +public final class PluginConsoleLogger + implements ConsoleLogger +{ + private final Log mojoLogger; + + public PluginConsoleLogger( Log mojoLogger ) + { + this.mojoLogger = mojoLogger; + } + + public boolean isDebugEnabled() + { + return mojoLogger.isDebugEnabled(); + } + + public void debug( String message ) + { + if ( mojoLogger.isDebugEnabled() ) + { + mojoLogger.debug( message ); — End diff – The purpose is to separate Mojo Logger. I cannot use Mojo in forked JVM. Many times the code uses the same classes and interfaces in in-plugin tests or forked-jvm tests but the same classes are extended and behave different in in these two places however the super type is used eveywhere like polymorphism. The same happened with ConsoleLogger and it has advantage because all can be developed independently and the logger would be same (unlike sometimes we used System.out and Mojo logger or console logger), so now it's only one. The important things is that `ConsoleLogger` does not need e.g. `isDebugEnabled` method but `AbstractSurefireMojo` used this for long time, so I decided to use concrete implementation class of `ConsoleLogger` in MOJO but that's the second reason to have this class here Unfortunately we use Java 5; otherwise you would see those annotations in methods implemented from interface via `@Override`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77448156

          — Diff: maven-failsafe-plugin/pom.xml —
          @@ -127,6 +127,19 @@
          <excludeTransitive>true</excludeTransitive>
          </configuration>
          </execution>
          + <execution>
          + <id>shared-logging-generated-sources</id>
          — End diff –

          Good point. I used m-shared-u:3.1.0 but there was compilation error I know from branch 3.0-rc1.
          One class of m-shared-u appeared in another package related to report. I don't remember the name of the class but it can be easily reproduced.
          This code would have very short life time because we already have branch `3.0-rc1` and one IT should be fixed and Surefire 2.x is gone.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77448156 — Diff: maven-failsafe-plugin/pom.xml — @@ -127,6 +127,19 @@ <excludeTransitive>true</excludeTransitive> </configuration> </execution> + <execution> + <id>shared-logging-generated-sources</id> — End diff – Good point. I used m-shared-u:3.1.0 but there was compilation error I know from branch 3.0-rc1. One class of m-shared-u appeared in another package related to report. I don't remember the name of the class but it can be easily reproduced. This code would have very short life time because we already have branch `3.0-rc1` and one IT should be fixed and Surefire 2.x is gone.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven-surefire/pull/117

          @hboutemy
          Hi Herve, I will amend the commit. So one commit would still appear however it is in progress. Surefire report has I think three place with logger only.
          Maybe important to know. I use ConsoleLogger in with methods like `debug/info/warning/errror` in in-plugin jvm and forked jvm as well. This was here all the history of Surefire but I only extended with few more methods. The implementations should be different in forked-jvm and simply, as higher design principle was, the surefire providers are slaves and they only encode and send a message to main process or receive a command to do. The main process does what it has to do; either creates a report of displays message in console. From the same principle in-plugin jvm is the only place where the ClassLoader should see ANSI and MessageBuilder of m-shared-u. So this separation is safe because such classes will never be loaded or failed to load in forked jvm and this prevents me from having ugly jira issues. So I decided to use SPI to separate implementation which is in surefire-common from surefire-api which is used everywhere. The SPI is a builder of colored messages only.
          So now we will have logs like `[INFO] Running MyTest` with colors instead of `Running MyTest`.
          Three advantages:
          + I fixed the issue you reported https://issues.apache.org/jira/browse/SUREFIRE-1254
          + many people reported bug that Surefire writes anything in consolve, so logger will again control the output and we don't have to add configuration parameter in plugin which is good, thus we fixed https://issues.apache.org/jira/browse/SUREFIRE-725 as well
          + and what I like is peace in code because as I told you before developers come and go to Surefire and everybody solved his problem without maintaining for long time. And that's the reason why logger was sometimes System.out, or System.err, or ConsoleLogger or mojo logger. I like when the code has internal principles that the attitude is just one; unlike use directly worked with stream PrintWriter which was wrapped stream of System.out which disallowed you to use normal logger like in Maven with slf4j and disallowed you to see messages like `[INFO] ...` etc.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/117 @hboutemy Hi Herve, I will amend the commit. So one commit would still appear however it is in progress. Surefire report has I think three place with logger only. Maybe important to know. I use ConsoleLogger in with methods like `debug/info/warning/errror` in in-plugin jvm and forked jvm as well. This was here all the history of Surefire but I only extended with few more methods. The implementations should be different in forked-jvm and simply, as higher design principle was, the surefire providers are slaves and they only encode and send a message to main process or receive a command to do. The main process does what it has to do; either creates a report of displays message in console. From the same principle in-plugin jvm is the only place where the ClassLoader should see ANSI and MessageBuilder of m-shared-u. So this separation is safe because such classes will never be loaded or failed to load in forked jvm and this prevents me from having ugly jira issues. So I decided to use SPI to separate implementation which is in surefire-common from surefire-api which is used everywhere. The SPI is a builder of colored messages only. So now we will have logs like ` [INFO] Running MyTest` with colors instead of `Running MyTest`. Three advantages: + I fixed the issue you reported https://issues.apache.org/jira/browse/SUREFIRE-1254 + many people reported bug that Surefire writes anything in consolve, so logger will again control the output and we don't have to add configuration parameter in plugin which is good, thus we fixed https://issues.apache.org/jira/browse/SUREFIRE-725 as well + and what I like is peace in code because as I told you before developers come and go to Surefire and everybody solved his problem without maintaining for long time. And that's the reason why logger was sometimes System.out, or System.err, or ConsoleLogger or mojo logger. I like when the code has internal principles that the attitude is just one; unlike use directly worked with stream PrintWriter which was wrapped stream of System.out which disallowed you to use normal logger like in Maven with slf4j and disallowed you to see messages like ` [INFO] ...` etc.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven-surefire/pull/117

          @hboutemy I will remove the SPI. The code will be simple if I just move the implementation to `surefire-common`. I thought that `surefire-common` appeared in classpath of forked jvm but I see now the classpath and no such artifact is in there.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/117 @hboutemy I will remove the SPI. The code will be simple if I just move the implementation to `surefire-common`. I thought that `surefire-common` appeared in classpath of forked jvm but I see now the classpath and no such artifact is in there.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77579430

          — Diff: surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/Level.java —
          @@ -0,0 +1,83 @@
          +package org.apache.maven.plugin.surefire.log.api;
          +
          +/*
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + *
          + * http://www.apache.org/licenses/LICENSE-2.0
          + *
          + * Unless required by applicable law or agreed to in writing,
          + * software distributed under the License is distributed on an
          + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
          + * KIND, either express or implied. See the License for the
          + * specific language governing permissions and limitations
          + * under the License.
          + */
          +
          +/**
          + * Standard log levels,

          {@link #DEBUG}

          {@link #INFO}

          {@link #WARN}

          {@link #ERROR}

          , used in console.
          + * Test result levels

          {@link #FAILURE}

          ,

          {@link #UNSTABLE}

          ,

          {@link #SUCCESS}

          .
          + * Writing to console without color via

          {@link #NO_COLOR}

          .
          + *
          + * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a>
          + * @since 2.19.2
          + */
          +public enum Level {
          + /**
          + * call

          {@link ColoredConsoleMessageBuilder#toColorless(CharSequence)}

          + */
          + NO_COLOR,
          +
          + /**
          + * defaults to bold, cyan
          + */
          + DEBUG,
          +
          + /**
          + * defaults to bold, green
          + */
          + INFO,
          +
          + /**
          + * defaults to bold, yellow
          + */
          + WARN,
          +
          + /**
          + * defaults to bold, red
          + */
          + ERROR,
          +
          + /**
          + * defaults to bold, green
          + */
          + FAILURE,
          +
          + /**
          + * defaults to bold, yellow
          + */
          + UNSTABLE,
          +
          + /**
          + * defaults to bold, red
          + */
          + SUCCESS;
          +
          + public static Level resolveLevel(boolean hasSuccessful, boolean hasFailure, boolean hasError,
          + boolean hasSkipped, boolean hasFlake) {
          + boolean isRed = hasFailure | hasError;
          + if (isRed) {
          — End diff –

          you'll need to reformat this class (and NullConsoleLogger) since they don't use Maven formatting conventions then are detected by Checkstyle

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77579430 — Diff: surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/Level.java — @@ -0,0 +1,83 @@ +package org.apache.maven.plugin.surefire.log.api; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Standard log levels, {@link #DEBUG} {@link #INFO} {@link #WARN} {@link #ERROR} , used in console. + * Test result levels {@link #FAILURE} , {@link #UNSTABLE} , {@link #SUCCESS} . + * Writing to console without color via {@link #NO_COLOR} . + * + * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a> + * @since 2.19.2 + */ +public enum Level { + /** + * call {@link ColoredConsoleMessageBuilder#toColorless(CharSequence)} + */ + NO_COLOR, + + /** + * defaults to bold, cyan + */ + DEBUG, + + /** + * defaults to bold, green + */ + INFO, + + /** + * defaults to bold, yellow + */ + WARN, + + /** + * defaults to bold, red + */ + ERROR, + + /** + * defaults to bold, green + */ + FAILURE, + + /** + * defaults to bold, yellow + */ + UNSTABLE, + + /** + * defaults to bold, red + */ + SUCCESS; + + public static Level resolveLevel(boolean hasSuccessful, boolean hasFailure, boolean hasError, + boolean hasSkipped, boolean hasFlake) { + boolean isRed = hasFailure | hasError; + if (isRed) { — End diff – you'll need to reformat this class (and NullConsoleLogger) since they don't use Maven formatting conventions then are detected by Checkstyle
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77579682

          — Diff: surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java —
          @@ -46,10 +48,8 @@
          import static org.apache.maven.surefire.booter.MasterProcessCommand.SKIP_SINCE_NEXT_TEST;
          import static org.apache.maven.surefire.booter.MasterProcessCommand.TEST_SET_FINISHED;
          import static org.apache.maven.surefire.booter.MasterProcessCommand.decode;
          -import static org.apache.maven.surefire.util.internal.StringUtils.encodeStringForForkCommunication;
          -import static org.apache.maven.surefire.util.internal.StringUtils.isNotBlank;
          -import static org.apache.maven.surefire.util.internal.StringUtils.isBlank;
          import static org.apache.maven.surefire.util.internal.DaemonThreadFactory.newDaemonThread;
          +import static org.apache.maven.surefire.util.internal.StringUtils.*;
          — End diff –

          import static org.apache.maven.surefire.util.internal.StringUtils.encodeStringForForkCommunication;
          import static org.apache.maven.surefire.util.internal.StringUtils.isBlank;
          import static org.apache.maven.surefire.util.internal.StringUtils.isNotBlank;
          import static org.apache.maven.surefire.util.internal.StringUtils.requireNonNull;

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77579682 — Diff: surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java — @@ -46,10 +48,8 @@ import static org.apache.maven.surefire.booter.MasterProcessCommand.SKIP_SINCE_NEXT_TEST; import static org.apache.maven.surefire.booter.MasterProcessCommand.TEST_SET_FINISHED; import static org.apache.maven.surefire.booter.MasterProcessCommand.decode; -import static org.apache.maven.surefire.util.internal.StringUtils.encodeStringForForkCommunication; -import static org.apache.maven.surefire.util.internal.StringUtils.isNotBlank; -import static org.apache.maven.surefire.util.internal.StringUtils.isBlank; import static org.apache.maven.surefire.util.internal.DaemonThreadFactory.newDaemonThread; +import static org.apache.maven.surefire.util.internal.StringUtils.*; — End diff – import static org.apache.maven.surefire.util.internal.StringUtils.encodeStringForForkCommunication; import static org.apache.maven.surefire.util.internal.StringUtils.isBlank; import static org.apache.maven.surefire.util.internal.StringUtils.isNotBlank; import static org.apache.maven.surefire.util.internal.StringUtils.requireNonNull;
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77579970

          — Diff: surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java —
          @@ -38,11 +38,16 @@
          import org.apache.maven.surefire.suite.RunResult;
          import org.apache.maven.surefire.testset.TestSetFailedException;

          +import static java.lang.System.*;
          — End diff –

          I really don't like this static import nor the next one: System.out and System.err in code is a lot more manageable that out and err with static import

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77579970 — Diff: surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java — @@ -38,11 +38,16 @@ import org.apache.maven.surefire.suite.RunResult; import org.apache.maven.surefire.testset.TestSetFailedException; +import static java.lang.System.*; — End diff – I really don't like this static import nor the next one: System.out and System.err in code is a lot more manageable that out and err with static import
          Hide
          hboutemy Hervé Boutemy added a comment -

          currently, after fixing errors reported by Checkstyle, I get a compile error in maven-surefire-common, which does not find package org.apache.maven.shared.utils.logging

          I want to see this branch running to see how the rendering looks like before eventually proposing updates in rendering code

          Show
          hboutemy Hervé Boutemy added a comment - currently, after fixing errors reported by Checkstyle, I get a compile error in maven-surefire-common, which does not find package org.apache.maven.shared.utils.logging I want to see this branch running to see how the rendering looks like before eventually proposing updates in rendering code
          Hide
          tibor17 Tibor Digana added a comment -

          I am still in progress.

          On Tue, Sep 6, 2016 at 8:52 AM, Hervé Boutemy (JIRA) <jira@apache.org>

          Show
          tibor17 Tibor Digana added a comment - I am still in progress. On Tue, Sep 6, 2016 at 8:52 AM, Hervé Boutemy (JIRA) <jira@apache.org>
          Hide
          tibor17 Tibor Digana added a comment -

          Hi Herve, I just wanted to declare that the work is in progress and make
          the people less nervous which means that the release is still closer

          On Tue, Sep 6, 2016 at 12:15 PM, Tibor Digana <tibordigana@apache.org>

          Show
          tibor17 Tibor Digana added a comment - Hi Herve, I just wanted to declare that the work is in progress and make the people less nervous which means that the release is still closer On Tue, Sep 6, 2016 at 12:15 PM, Tibor Digana <tibordigana@apache.org>
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77626386

          — Diff: surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/Level.java —
          @@ -0,0 +1,83 @@
          +package org.apache.maven.plugin.surefire.log.api;
          +
          +/*
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + *
          + * http://www.apache.org/licenses/LICENSE-2.0
          + *
          + * Unless required by applicable law or agreed to in writing,
          + * software distributed under the License is distributed on an
          + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
          + * KIND, either express or implied. See the License for the
          + * specific language governing permissions and limitations
          + * under the License.
          + */
          +
          +/**
          + * Standard log levels,

          {@link #DEBUG}

          {@link #INFO}

          {@link #WARN}

          {@link #ERROR}

          , used in console.
          + * Test result levels

          {@link #FAILURE}

          ,

          {@link #UNSTABLE}

          ,

          {@link #SUCCESS}

          .
          + * Writing to console without color via

          {@link #NO_COLOR}

          .
          + *
          + * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a>
          + * @since 2.19.2
          + */
          +public enum Level {
          + /**
          + * call

          {@link ColoredConsoleMessageBuilder#toColorless(CharSequence)}

          + */
          + NO_COLOR,
          +
          + /**
          + * defaults to bold, cyan
          + */
          + DEBUG,
          +
          + /**
          + * defaults to bold, green
          + */
          + INFO,
          +
          + /**
          + * defaults to bold, yellow
          + */
          + WARN,
          +
          + /**
          + * defaults to bold, red
          + */
          + ERROR,
          +
          + /**
          + * defaults to bold, green
          + */
          + FAILURE,
          +
          + /**
          + * defaults to bold, yellow
          + */
          + UNSTABLE,
          +
          + /**
          + * defaults to bold, red
          + */
          + SUCCESS;
          +
          + public static Level resolveLevel(boolean hasSuccessful, boolean hasFailure, boolean hasError,
          + boolean hasSkipped, boolean hasFlake) {
          + boolean isRed = hasFailure | hasError;
          + if (isRed) {
          — End diff –

          yes, this has benn done - yet not committed.
          I am currently running build and one before last module failed `surefire-setup-integration-tests` because of wrong shading.
          The last module is `surefire-integration-tests` where I should switch off collors and then I have some activity to compare all binaries against binaries of previous release 2.19.1.
          Then I will run manual testing and compare console with old version and several features which alter the console like `rerun`, `assumptions` and reports.
          Maybe we should then test together.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77626386 — Diff: surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/Level.java — @@ -0,0 +1,83 @@ +package org.apache.maven.plugin.surefire.log.api; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Standard log levels, {@link #DEBUG} {@link #INFO} {@link #WARN} {@link #ERROR} , used in console. + * Test result levels {@link #FAILURE} , {@link #UNSTABLE} , {@link #SUCCESS} . + * Writing to console without color via {@link #NO_COLOR} . + * + * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a> + * @since 2.19.2 + */ +public enum Level { + /** + * call {@link ColoredConsoleMessageBuilder#toColorless(CharSequence)} + */ + NO_COLOR, + + /** + * defaults to bold, cyan + */ + DEBUG, + + /** + * defaults to bold, green + */ + INFO, + + /** + * defaults to bold, yellow + */ + WARN, + + /** + * defaults to bold, red + */ + ERROR, + + /** + * defaults to bold, green + */ + FAILURE, + + /** + * defaults to bold, yellow + */ + UNSTABLE, + + /** + * defaults to bold, red + */ + SUCCESS; + + public static Level resolveLevel(boolean hasSuccessful, boolean hasFailure, boolean hasError, + boolean hasSkipped, boolean hasFlake) { + boolean isRed = hasFailure | hasError; + if (isRed) { — End diff – yes, this has benn done - yet not committed. I am currently running build and one before last module failed `surefire-setup-integration-tests` because of wrong shading. The last module is `surefire-integration-tests` where I should switch off collors and then I have some activity to compare all binaries against binaries of previous release 2.19.1. Then I will run manual testing and compare console with old version and several features which alter the console like `rerun`, `assumptions` and reports. Maybe we should then test together.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77626502

          — Diff: surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java —
          @@ -46,10 +48,8 @@
          import static org.apache.maven.surefire.booter.MasterProcessCommand.SKIP_SINCE_NEXT_TEST;
          import static org.apache.maven.surefire.booter.MasterProcessCommand.TEST_SET_FINISHED;
          import static org.apache.maven.surefire.booter.MasterProcessCommand.decode;
          -import static org.apache.maven.surefire.util.internal.StringUtils.encodeStringForForkCommunication;
          -import static org.apache.maven.surefire.util.internal.StringUtils.isNotBlank;
          -import static org.apache.maven.surefire.util.internal.StringUtils.isBlank;
          import static org.apache.maven.surefire.util.internal.DaemonThreadFactory.newDaemonThread;
          +import static org.apache.maven.surefire.util.internal.StringUtils.*;
          — End diff –

          yes this is change in my local code as well.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77626502 — Diff: surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java — @@ -46,10 +48,8 @@ import static org.apache.maven.surefire.booter.MasterProcessCommand.SKIP_SINCE_NEXT_TEST; import static org.apache.maven.surefire.booter.MasterProcessCommand.TEST_SET_FINISHED; import static org.apache.maven.surefire.booter.MasterProcessCommand.decode; -import static org.apache.maven.surefire.util.internal.StringUtils.encodeStringForForkCommunication; -import static org.apache.maven.surefire.util.internal.StringUtils.isNotBlank; -import static org.apache.maven.surefire.util.internal.StringUtils.isBlank; import static org.apache.maven.surefire.util.internal.DaemonThreadFactory.newDaemonThread; +import static org.apache.maven.surefire.util.internal.StringUtils.*; — End diff – yes this is change in my local code as well.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77627125

          — Diff: surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java —
          @@ -38,11 +38,16 @@
          import org.apache.maven.surefire.suite.RunResult;
          import org.apache.maven.surefire.testset.TestSetFailedException;

          +import static java.lang.System.*;
          — End diff –

          My IDEA added star. I should fix it in her configuration.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77627125 — Diff: surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java — @@ -38,11 +38,16 @@ import org.apache.maven.surefire.suite.RunResult; import org.apache.maven.surefire.testset.TestSetFailedException; +import static java.lang.System.*; — End diff – My IDEA added star. I should fix it in her configuration.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven-surefire/pull/117

          @hboutemy now we can test. All unit tests passed and I picked up first IT and passed successfully. So I am going to run all ITs. The content of binaries is expected and I compared it with previous release.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/117 @hboutemy now we can test. All unit tests passed and I picked up first IT and passed successfully. So I am going to run all ITs. The content of binaries is expected and I compared it with previous release.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on the issue:

          https://github.com/apache/maven-surefire/pull/117

          @hboutemy I found NPE so that consoleLogger is null. I will fix it and run the tests again. Some tests were successful.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/117 @hboutemy I found NPE so that consoleLogger is null. I will fix it and run the tests again. Some tests were successful.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77741146

          — Diff: maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java —
          @@ -34,10 +34,11 @@
          import org.apache.maven.plugins.annotations.Mojo;
          import org.apache.maven.plugins.annotations.Parameter;
          import org.apache.maven.plugins.annotations.ResolutionScope;
          -import org.apache.maven.shared.utils.ReaderFactory;
          import org.apache.maven.shared.utils.StringUtils;
          import org.apache.maven.surefire.suite.RunResult;

          +import static org.apache.maven.shared.utils.ReaderFactory.FILE_ENCODING;
          +
          — End diff –

          is it really intentional to reformat everything to have static import on any static access? I don't find it convenient in general.

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77741146 — Diff: maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java — @@ -34,10 +34,11 @@ import org.apache.maven.plugins.annotations.Mojo; import org.apache.maven.plugins.annotations.Parameter; import org.apache.maven.plugins.annotations.ResolutionScope; -import org.apache.maven.shared.utils.ReaderFactory; import org.apache.maven.shared.utils.StringUtils; import org.apache.maven.surefire.suite.RunResult; +import static org.apache.maven.shared.utils.ReaderFactory.FILE_ENCODING; + — End diff – is it really intentional to reformat everything to have static import on any static access? I don't find it convenient in general.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hboutemy commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r77742105

          — Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java —
          @@ -0,0 +1,126 @@
          +package org.apache.maven.plugin.surefire.log;
          +
          +/*
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + *
          + * http://www.apache.org/licenses/LICENSE-2.0
          + *
          + * Unless required by applicable law or agreed to in writing,
          + * software distributed under the License is distributed on an
          + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
          + * KIND, either express or implied. See the License for the
          + * specific language governing permissions and limitations
          + * under the License.
          + */
          +
          +import org.apache.maven.plugin.logging.Log;
          +import org.apache.maven.surefire.report.ConsoleLogger;
          +
          +/**
          + * Wrapper logger of miscellaneous (Maven 2.2.1 or 3.1) implementations of

          {@link Log}

          .
          + * Calling

          {@link Log#isInfoEnabled()}

          before

          {@link Log#info(CharSequence)}

          due to Maven 2.2.1.
          + *
          + * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a>
          + * @since 2.19.2
          + * @see ConsoleLogger
          + */
          +public final class PluginConsoleLogger
          + implements ConsoleLogger
          +{
          + private final Log mojoLogger;
          +
          + public PluginConsoleLogger( Log mojoLogger )
          +

          { + this.mojoLogger = mojoLogger; + }

          +
          + public boolean isDebugEnabled()
          +

          { + return mojoLogger.isDebugEnabled(); + }

          +
          + public void debug( String message )
          + {
          + if ( mojoLogger.isDebugEnabled() )
          + {
          + mojoLogger.debug( message );
          — End diff –

          here, I completely missed the point: ok, now I understand that it's just proxying log call from one API to the other

          my fear is more on DefaultColoredConsoleMessageBuilder, where it seems to add color to each log message: I'll test

          Show
          githubbot ASF GitHub Bot added a comment - Github user hboutemy commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r77742105 — Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java — @@ -0,0 +1,126 @@ +package org.apache.maven.plugin.surefire.log; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.plugin.logging.Log; +import org.apache.maven.surefire.report.ConsoleLogger; + +/** + * Wrapper logger of miscellaneous (Maven 2.2.1 or 3.1) implementations of {@link Log} . + * Calling {@link Log#isInfoEnabled()} before {@link Log#info(CharSequence)} due to Maven 2.2.1. + * + * @author <a href="mailto:tibordigana@apache.org">Tibor Digana (tibor17)</a> + * @since 2.19.2 + * @see ConsoleLogger + */ +public final class PluginConsoleLogger + implements ConsoleLogger +{ + private final Log mojoLogger; + + public PluginConsoleLogger( Log mojoLogger ) + { + this.mojoLogger = mojoLogger; + } + + public boolean isDebugEnabled() + { + return mojoLogger.isDebugEnabled(); + } + + public void debug( String message ) + { + if ( mojoLogger.isDebugEnabled() ) + { + mojoLogger.debug( message ); — End diff – here, I completely missed the point: ok, now I understand that it's just proxying log call from one API to the other my fear is more on DefaultColoredConsoleMessageBuilder, where it seems to add color to each log message: I'll test
          Show
          tibor17 Tibor Digana added a comment - commit https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commitdiff;h=6a79127ab63273f0f1f5268c65e4806761871a46
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 closed the pull request at:

          https://github.com/apache/maven-surefire/pull/117

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 closed the pull request at: https://github.com/apache/maven-surefire/pull/117
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Tibor17 commented on a diff in the pull request:

          https://github.com/apache/maven-surefire/pull/117#discussion_r79264943

          — Diff: maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java —
          @@ -34,10 +34,11 @@
          import org.apache.maven.plugins.annotations.Mojo;
          import org.apache.maven.plugins.annotations.Parameter;
          import org.apache.maven.plugins.annotations.ResolutionScope;
          -import org.apache.maven.shared.utils.ReaderFactory;
          import org.apache.maven.shared.utils.StringUtils;
          import org.apache.maven.surefire.suite.RunResult;

          +import static org.apache.maven.shared.utils.ReaderFactory.FILE_ENCODING;
          +
          — End diff –

          I use it for several purposes. When line is getting to lone around 120 characters and the constant is just a storage, or assertion statement when it is ugly to read the class; otherwise the whole statement is not verbal enough if class appears. I use IntelliJ IDEA which navigates me to the class where the constant is stored. I do not know how bout Eclipse abilities. I tried to use same name of method in static import and Java compiler failed, so it's safe compiler.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/117#discussion_r79264943 — Diff: maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java — @@ -34,10 +34,11 @@ import org.apache.maven.plugins.annotations.Mojo; import org.apache.maven.plugins.annotations.Parameter; import org.apache.maven.plugins.annotations.ResolutionScope; -import org.apache.maven.shared.utils.ReaderFactory; import org.apache.maven.shared.utils.StringUtils; import org.apache.maven.surefire.suite.RunResult; +import static org.apache.maven.shared.utils.ReaderFactory.FILE_ENCODING; + — End diff – I use it for several purposes. When line is getting to lone around 120 characters and the constant is just a storage, or assertion statement when it is ugly to read the class; otherwise the whole statement is not verbal enough if class appears. I use IntelliJ IDEA which navigates me to the class where the constant is stored. I do not know how bout Eclipse abilities. I tried to use same name of method in static import and Java compiler failed, so it's safe compiler.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build maven-surefire #1609 (See https://builds.apache.org/job/maven-surefire/1609/)
          SUREFIRE-1254 add color messages (tibor17: rev 6a79127ab63273f0f1f5268c65e4806761871a46)

          • (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/NoServiceInterface.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire735ForkFailWithRedirectConsoleOutputIT.java
          • (delete) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Not2xCompatible.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Junit47concurrencyIT.java
          • (add) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/DefaultConsoleReporter.java
          • (edit) surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportParser.java
          • (edit) surefire-report-parser/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportParserTest.java
          • (edit) surefire-setup-integration-tests/src/test/java/org/apache/maven/surefire/its/StagedLocalRepoHelper.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/SharedThreadPoolStrategy.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/providerapi/ProviderParameters.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java
          • (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/ConsoleLogger.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleReporter.java
          • (delete) surefire-api/src/test/java/org/apache/maven/surefire/report/MockReporter.java
          • (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
          • (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/ConsoleLoggerDecorator.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java
          • (edit) maven-surefire-common/pom.xml
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/SchedulingStrategy.java
          • (delete) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/Logger.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-1080-parallel-fork-double-test/pom.xml
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/InPluginVMSurefireStarter.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1122ParallelAndFlakyTestsIT.java
          • (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/PrintStreamLogger.java
          • (edit) surefire-report-parser/pom.xml
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/surefire/report/RunStatistics.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/Scheduler.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1136CwdPropagationInForkedModeIT.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/ConcurrentRunListener.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DirectConsoleOutput.java
          • (edit) pom.xml
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
          • (edit) maven-failsafe-plugin/pom.xml
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/ClassesParallelRunListener.java
          • (edit) surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/TestSetMockReporterFactory.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/ForkClient.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-1122-parallel-and-flakyTests/pom.xml
          • (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/SPImpl1.java
          • (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
          • (delete) surefire-api/src/main/java/org/apache/maven/surefire/report/DefaultConsoleReporter.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire806SpecifiedTestControlsIT.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java
          • (edit) surefire-providers/surefire-junit4/src/test/java/org/apache/maven/surefire/junit4/JUnit4ProviderTest.java
          • (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/SchedulingStrategiesTest.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/AbstractThreadPoolStrategy.java
          • (edit) surefire-api/pom.xml
          • (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/JUnitCoreTester.java
          • (delete) surefire-api/src/main/java/org/apache/maven/surefire/report/ConsoleLogger.java
          • (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/NativeStdErrStreamConsumer.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java
          • (edit) maven-surefire-report-plugin/pom.xml
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/BaseProviderFactory.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/report/ConsoleOutputCapture.java
          • (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/ConcurrentRunListenerTest.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/MethodsParallelRunListener.java
          • (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/CustomizedImpl.java
          • (edit) surefire-integration-tests/pom.xml
          • (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java
          • (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
          • (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/FailsafeReportMojo.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilder.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreWrapper.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ProviderDetector.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/report/DefaultDirectConsoleReporter.java
          • (edit) maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
          • (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/ExistingServiceInterface.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/InvokerStrategy.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
          • (add) maven-surefire-common/src/test/resources/META-INF/services/org.apache.maven.surefire.spi.EmptyServiceInterface
          • (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/ConsoleLoggerUtils.java
          • (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/DefaultImpl.java
          • (add) maven-surefire-common/src/main/java/org/apache/maven/surefire/spi/ServiceLoader.java
          • (add) maven-surefire-common/src/test/resources/META-INF/services/org.apache.maven.surefire.spi.IDefault
          • (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java
          • (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/SurefireReflector.java
          • (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/SPITest.java
          • (edit) surefire-integration-tests/src/test/resources/surefire-1082-parallel-junit-parameterized/pom.xml
          • (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/Level.java
          • (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
          • (add) surefire-logger-api/pom.xml
          • (edit) surefire-report-parser/src/test/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParserTest.java
          • (edit) maven-surefire-plugin/pom.xml
          • (add) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefireReflectorTest.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
          • (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/SPImpl2.java
          • (edit) surefire-integration-tests/src/test/resources/concurrentjunit47/pom.xml
          • (add) maven-surefire-common/src/test/resources/META-INF/services/org.apache.maven.surefire.spi.ExistingServiceInterface
          • (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerUtilTest.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/MockReporter.java
          • (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/EmptyServiceInterface.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/JUnit4SuiteTest.java
          • (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkingRunListenerTest.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetStats.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/SingleThreadScheduler.java
          • (add) surefire-api/src/main/java/org/apache/maven/surefire/report/ConsoleStream.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/StartupReportConfiguration.java
          • (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/IDefault.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/NonSharedThreadPoolStrategy.java
          • (edit) README.md
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreProvider.java
          • (add) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/PluginConsoleLogger.java
          • (edit) maven-surefire-plugin/src/site/apt/index.apt.vm
          • (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/NullConsoleLogger.java
          • (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java
          • (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/Surefire746Test.java
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/CommonReflector.java
          • (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1158RemoveInfoLinesIT.java
          • (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/SchedulingStrategies.java
          • (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java
          • (edit) surefire-providers/surefire-junit3/src/main/java/org/apache/maven/surefire/junit/JUnit3Provider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build maven-surefire #1609 (See https://builds.apache.org/job/maven-surefire/1609/ ) SUREFIRE-1254 add color messages (tibor17: rev 6a79127ab63273f0f1f5268c65e4806761871a46) (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/NoServiceInterface.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire735ForkFailWithRedirectConsoleOutputIT.java (delete) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Not2xCompatible.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Junit47concurrencyIT.java (add) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/DefaultConsoleReporter.java (edit) surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportParser.java (edit) surefire-report-parser/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportParserTest.java (edit) surefire-setup-integration-tests/src/test/java/org/apache/maven/surefire/its/StagedLocalRepoHelper.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/SharedThreadPoolStrategy.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/providerapi/ProviderParameters.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/ConsoleLogger.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleReporter.java (delete) surefire-api/src/test/java/org/apache/maven/surefire/report/MockReporter.java (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/ConsoleLoggerDecorator.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java (edit) maven-surefire-common/pom.xml (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/SchedulingStrategy.java (delete) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/Logger.java (edit) surefire-integration-tests/src/test/resources/surefire-1080-parallel-fork-double-test/pom.xml (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/InPluginVMSurefireStarter.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1122ParallelAndFlakyTestsIT.java (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/PrintStreamLogger.java (edit) surefire-report-parser/pom.xml (edit) maven-surefire-common/src/main/java/org/apache/maven/surefire/report/RunStatistics.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/Scheduler.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1136CwdPropagationInForkedModeIT.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/ConcurrentRunListener.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DirectConsoleOutput.java (edit) pom.xml (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java (edit) maven-failsafe-plugin/pom.xml (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/ClassesParallelRunListener.java (edit) surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/TestSetMockReporterFactory.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/ForkClient.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java (edit) surefire-integration-tests/src/test/resources/surefire-1122-parallel-and-flakyTests/pom.xml (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/SPImpl1.java (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java (delete) surefire-api/src/main/java/org/apache/maven/surefire/report/DefaultConsoleReporter.java (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire806SpecifiedTestControlsIT.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java (edit) surefire-providers/surefire-junit4/src/test/java/org/apache/maven/surefire/junit4/JUnit4ProviderTest.java (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/SchedulingStrategiesTest.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/AbstractThreadPoolStrategy.java (edit) surefire-api/pom.xml (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/JUnitCoreTester.java (delete) surefire-api/src/main/java/org/apache/maven/surefire/report/ConsoleLogger.java (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/NativeStdErrStreamConsumer.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/FileReporter.java (edit) maven-surefire-report-plugin/pom.xml (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/BaseProviderFactory.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/report/ConsoleOutputCapture.java (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/ConcurrentRunListenerTest.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/MethodsParallelRunListener.java (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/CustomizedImpl.java (edit) surefire-integration-tests/pom.xml (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/FailsafeReportMojo.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilder.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreWrapper.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ProviderDetector.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/report/DefaultDirectConsoleReporter.java (edit) maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/ExistingServiceInterface.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/InvokerStrategy.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java (add) maven-surefire-common/src/test/resources/META-INF/services/org.apache.maven.surefire.spi.EmptyServiceInterface (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/ConsoleLoggerUtils.java (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/DefaultImpl.java (add) maven-surefire-common/src/main/java/org/apache/maven/surefire/spi/ServiceLoader.java (add) maven-surefire-common/src/test/resources/META-INF/services/org.apache.maven.surefire.spi.IDefault (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/SurefireReflector.java (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/SPITest.java (edit) surefire-integration-tests/src/test/resources/surefire-1082-parallel-junit-parameterized/pom.xml (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/Level.java (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java (add) surefire-logger-api/pom.xml (edit) surefire-report-parser/src/test/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParserTest.java (edit) maven-surefire-plugin/pom.xml (add) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefireReflectorTest.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/SPImpl2.java (edit) surefire-integration-tests/src/test/resources/concurrentjunit47/pom.xml (add) maven-surefire-common/src/test/resources/META-INF/services/org.apache.maven.surefire.spi.ExistingServiceInterface (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerUtilTest.java (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/MockReporter.java (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/EmptyServiceInterface.java (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/JUnit4SuiteTest.java (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkingRunListenerTest.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetStats.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/SingleThreadScheduler.java (add) surefire-api/src/main/java/org/apache/maven/surefire/report/ConsoleStream.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/StartupReportConfiguration.java (add) maven-surefire-common/src/test/java/org/apache/maven/surefire/spi/IDefault.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/NonSharedThreadPoolStrategy.java (edit) README.md (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreProvider.java (add) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/PluginConsoleLogger.java (edit) maven-surefire-plugin/src/site/apt/index.apt.vm (add) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/NullConsoleLogger.java (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/Surefire746Test.java (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/CommonReflector.java (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1158RemoveInfoLinesIT.java (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/SchedulingStrategies.java (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java (edit) surefire-providers/surefire-junit3/src/main/java/org/apache/maven/surefire/junit/JUnit3Provider.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-surefire #1614 (See https://builds.apache.org/job/maven-surefire/1614/)
          SUREFIRE-1254 add color messages (tibor17: rev c03f6ed5e31b16e503b56b650b98a8c333b084c7)

          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java
            SUREFIRE-1254 add color messages (tibor17: rev ed27af4d260a9e5dc429a3a7ddafd11188bfe5d2)
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetStats.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-surefire #1614 (See https://builds.apache.org/job/maven-surefire/1614/ ) SUREFIRE-1254 add color messages (tibor17: rev c03f6ed5e31b16e503b56b650b98a8c333b084c7) (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java SUREFIRE-1254 add color messages (tibor17: rev ed27af4d260a9e5dc429a3a7ddafd11188bfe5d2) (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetStats.java
          Hide
          hboutemy Hervé Boutemy added a comment - - edited

          I like the overall result: great work

          a few remarks:

          • given the big change in output (with log level printing), I suppose 2.19.2 could be renamed 2.20
          • "Skipped" tests styling seems inconsistent: sometimes it is rendered as failure, and sometimes as warning: and I'm not even sure if a skipped test is something abnormal (I'll attach a screenshot)
          Show
          hboutemy Hervé Boutemy added a comment - - edited I like the overall result: great work a few remarks: given the big change in output (with log level printing), I suppose 2.19.2 could be renamed 2.20 "Skipped" tests styling seems inconsistent: sometimes it is rendered as failure, and sometimes as warning: and I'm not even sure if a skipped test is something abnormal (I'll attach a screenshot)
          Hide
          tibor17 Tibor Digana added a comment -

          sometimes as warning
          I will check it out again. I guess your test was like this:
          assumeTrue( false );
          or different?

          On Sat, Sep 17, 2016 at 11:49 AM, Hervé Boutemy (JIRA) <jira@apache.org>
          wrote:

          Show
          tibor17 Tibor Digana added a comment - sometimes as warning I will check it out again. I guess your test was like this: assumeTrue( false ); or different? On Sat, Sep 17, 2016 at 11:49 AM, Hervé Boutemy (JIRA) <jira@apache.org> wrote:
          Hide
          tibor17 Tibor Digana added a comment -

          I fixed it. Now Skipped # is printed in yellow/warning.
          CI will handle this in a while.

          On Sat, Sep 17, 2016 at 11:53 AM, Hervé Boutemy (JIRA) <jira@apache.org>

          Show
          tibor17 Tibor Digana added a comment - I fixed it. Now Skipped # is printed in yellow/warning. CI will handle this in a while. On Sat, Sep 17, 2016 at 11:53 AM, Hervé Boutemy (JIRA) <jira@apache.org>
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-surefire #1615 (See https://builds.apache.org/job/maven-surefire/1615/)
          SUREFIRE-1254 add color messages (tibor17: rev 7617fc089ffacda47ca3b66656ff30ba3bbf1d25)

          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetStats.java
            SUREFIRE-1254 add color messages (tibor17: rev b6d221295e3f0691413844cf023a56d514c035f5)
          • (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetStats.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-surefire #1615 (See https://builds.apache.org/job/maven-surefire/1615/ ) SUREFIRE-1254 add color messages (tibor17: rev 7617fc089ffacda47ca3b66656ff30ba3bbf1d25) (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetStats.java SUREFIRE-1254 add color messages (tibor17: rev b6d221295e3f0691413844cf023a56d514c035f5) (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetStats.java

            People

            • Assignee:
              tibor17 Tibor Digana
              Reporter:
              hboutemy Hervé Boutemy
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development