[SUREFIRE-1222] ForkClient attempts to consume unrelated lines

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.17
• Fix Version/s: 3.0.0-M4
• Component/s: Maven Surefire Plugin, process forking
• Environment: Oracle JDK7 (build 1.7.0_79-b15); Linux 3.13 x86_64 with default locale cs_CZ
• Assignee: Tibor Digana
• Reporter: Martin Kouba
• Created: 29/Jan/16 14:10
• Updated: 23/May/19 20:01
• Resolved: 25/Mar/19 22:29

Description

This month the Weld SE test suite suddenly started to fail on a Linux machine with Oracle JDK7 and the default locale cs_CZ:

Caused by: java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.lang.String.substring(String.java:1911)
	at org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:128)
	at org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:67)
	at java.lang.Thread.run(Thread.java:745)

A java.util.logging.Logger is used in the forked process. The exception occurs when the following log message is written to the standard output:

I 29, 2016 2:01:43 ODP. org.jboss.arquillian.container.se.server.Main main

We have found out that the timestamp I 29, 2016 2:01:43 (i.e. 2016-01-29 14:01:43) is incorrectly parsed as ForkingRunListener.BOOTERCODE_SYSPROPS operation.

I think the protocol should be robust enough to avoid similar collisions.

Issue Links

• relates to: SUREFIRE-1220 Surefire never outputs UTF-8 under Windows
• links to: GitHub Pull Request #210
• links to: GitHub Pull Request #223