[SUREFIRE-1155] REFACTORING for Java 5

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.18.1
• Fix Version/s: 2.19
• Component/s: Maven Failsafe Plugin, Maven Surefire Plugin
• Assignee: Tibor Digana
• Reporter: Tibor Digana
• Created: 06/May/15 07:25
• Updated: 06/May/15 07:26
• Resolved: 06/May/15 07:26

Description

This is the list of refactoring activities

Java 5 for-each instead of Iterator
optimized loops
optimized branching
some conditions in if-else could not happen -> therefore was simplified
improved loops variables
optimized use of this pointer
using Java Generics instead of java.util.Properties
removed unnecessary cast
boolean instead of Boolean
isEmpty() instead of Collection#size() == 0
removed unused code
resolved warnings shown by IntelliJ IDEA
use Arrays.asList( o ) to Collections.singletonList( o ) with single object
@SuppressWarnings where code generics cannot be improved
substitute Java 4 StringBuilder with String concatination for better code clarity. Java Compilet 5 will compile to use StringBuilder in bytecode.
using ternary operator
added remark @todo use try-with-resources JDK7, search in all code
get rid of Class[] in Reflection and use var args
caught InvocationTargetException and use exception cause in rethrown RuntimeException