[SUBMARINE-49] Add more test coverage to RunJobParameters - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Sub-task
Status: Resolved
Priority: Major
Resolution: Won't Fix
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
- pull-request-available

Description

There are some good tests in org.apache.hadoop.yarn.submarine.client.cli.TestRunJobCliParsing, but these are not testing all fields set by method org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline.

Some more extensive testing is needed in this area.

As an added bonus, the code org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline could be cleaned up a bit.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

SUBMARINE-49.008.patch
01/Aug/19 12:55
156 kB
Szilard Nemeth
SUBMARINE-49.008.patch
15/Jul/19 14:36
156 kB
Adam Antal
SUBMARINE-49.008.patch
15/Jul/19 11:11
156 kB
Szilard Nemeth
SUBMARINE-49.008.patch
11/Jul/19 15:02
156 kB
Adam Antal
SUBMARINE-49.007.patch
10/Jul/19 14:29
154 kB
Adam Antal
SUBMARINE-49.007.patch
19/May/19 08:46
154 kB
Szilard Nemeth
SUBMARINE-49.006.patch
15/May/19 14:11
153 kB
Szilard Nemeth
SUBMARINE-49.005.patch
13/May/19 07:31
153 kB
Szilard Nemeth
SUBMARINE-49.004.patch
11/May/19 11:09
148 kB
Szilard Nemeth
SUBMARINE-49.004.patch
10/May/19 18:03
148 kB
Szilard Nemeth
SUBMARINE-49.003.patch
14/Apr/19 19:14
106 kB
Szilard Nemeth
SUBMARINE-49.002.patch
11/Apr/19 14:16
106 kB
Szilard Nemeth
SUBMARINE-49.001.patch
09/Apr/19 11:27
79 kB
Szilard Nemeth

Issue Links

links to

GitHub Pull Request #114

Activity

People

Assignee:: Adam Antal

Reporter:: Szilard Nemeth

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 16/Mar/19 00:30

Updated:: 04/Dec/19 10:39

Resolved:: 04/Dec/19 10:38

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

20m