Details
-
Improvement
-
Status: Reopened
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
-
None
Description
For each provider where the proposed re-factoring improvement is feasible, create sub-tasks to perform the following:
1) Add DocumentClassifier(s) capable of classifying each provider-specific type combination the provider expects to receive from all upstream end-points.
2) Add a test demonstrating one and only one of these Classifiers returns true across a set of example origin documents.
3) Add an ActivityConverter for each objectType/Verb combination the provider expects to emit. requiredClass should be one of String.class, ObjectNode.class, or a POJO which extends Serializable.
4) Add tests demonstrating that individual ActivityConverters are able to convert the set of example origin documents into activities with correct objectType/verb.
5) Add tests demonstrating that ActivityConverterProcessor is able to convert the set of example origin documents into activities with correct objectType/verb.
6) Add a StreamsDateTimeFormat for each non-RFC3339 date string the provider expects to receive.
7) Add a test demonstrating that StreamsJacksonMapper is able to convert matching date strings to DateTimes.
8) Mark legacy TypeConverters as Deprecated, or delete if they are now unmaintainable.
9) Mark legacy EventClassifiers as Deprecated, or delete if they are now unmaintainable.
10) Mark legacy StreamsMappers as Deprecated, or delete if they are now unmaintainable.
For any provider where the proposed re-factoring improvement is not feasible, document why in the module README and/or create issues for whatever refactoring would be necessary to make that provider compatible with ActivityConverterProcessor.