[STRATOS-749] Redundant and unused variables in puppet3-agent/init.sh

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Fix Version/s: FUTURE
• Component/s: Puppet
• Assignee: Unassigned
• Reporter: Chamila de Alwis
• Created: 18/Aug/14 08:30
• Updated: 16/Jul/15 20:46

Description

Following variables seem to be unused after declaration.

Line 38: PUPPETD=`which puppet` is declared and used subsequently in PUPPETAGENT and COMMAND. However when actually running the puppet agent at line 126 PUPPET is declared again and used to construct the puppet agent command.

The method read_master() is also not used in the script.

These can be removed for clarity since they are declared again when puppet agent command is actually used.