[STRATOS-1660] Obsolete timeout calculation logic is buggy

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.4, 4.1.5
• Fix Version/s: 4.1.5
• Component/s: Autoscaler
• Assignee: Akila Perera
• Reporter: Akila Perera
• Created: 14/Jun/16 09:42
• Updated: 03/Jul/16 17:56
• Resolved: 17/Jun/16 08:30

Description

https://github.com/apache/stratos/blob/4.1.5/components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/context/partition/ClusterLevelPartitionContext.java#L750

long obsoleteTime = System.currentTimeMillis() - obsoleteMember.getInitTime();

The above does not take into account instances that were moved to the obsolete list while in active status. In that case, it should be

long obsoleteTime = System.currentTimeMillis() - obsoleteMember.getObsoleteInitTime();

It should handle both inactive members (did not become active after being created), and faulty members.