[STRATOS-1285] Wrong HTTP status code returned - DELETE /cartridgeGroups/{groupDefinitionName}

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.1.0 Alpha
• Component/s: REST API
• Assignee: Unassigned
• Reporter: Mariangela Hills
• Created: 24/Mar/15 06:28
• Updated: 05/May/15 05:53
• Resolved: 05/May/15 05:53

Description

The following three issues were identified:

(1) Normally the 204 HTTP status code should be returned when deleting. However, when executing DELETE /cartridgeGroups/

{groupDefinitionName}

the 200 HTTP status code is returned [1], which is incorrect.

(2) The success message states service group. However, now we refer to a service group as a cartridge group. Therefore, the success message needs to be changed.

For example:

{"statusCode":204,"successMessage":"Cartridge Group deleted successfully: [service-group] group6"}

HTTP Output - [1]
Admin16s-MacBook-Air:samples Admin16$ curl -X DELETE -H "Content-Type: application/json" -k -v -u admin:admin https://localhost:9443/api/cartridgeGroups/group6

• About to connect() to localhost port 9443 (#0)
• Trying ::1...
• connected
• Connected to localhost (::1) port 9443 (#0)
• SSLv3, TLS handshake, Client hello (1):
• SSLv3, TLS handshake, Server hello (2):
• SSLv3, TLS handshake, CERT (11):
• SSLv3, TLS handshake, Server key exchange (12):
• SSLv3, TLS handshake, Server finished (14):
• SSLv3, TLS handshake, Client key exchange (16):
• SSLv3, TLS change cipher, Client hello (1):
• SSLv3, TLS handshake, Finished (20):
• SSLv3, TLS change cipher, Client hello (1):
• SSLv3, TLS handshake, Finished (20):
• SSL connection using DHE-RSA-AES256-SHA
• Server certificate:
• subject: C=US; ST=CA; L=Mountain View; O=WSO2; CN=localhost
• start date: 2010-02-19 07:02:26 GMT
• expire date: 2035-02-13 07:02:26 GMT
• common name: localhost (matched)
• issuer: C=US; ST=CA; L=Mountain View; O=WSO2; CN=localhost
• SSL certificate verify result: unable to get local issuer certificate (20), continuing anyway.
• Server auth using Basic with user 'admin'
  > DELETE /api/cartridgeGroups/group6 HTTP/1.1
  > Authorization: Basic YWRtaW46YWRtaW4=
  > User-Agent: curl/7.24.0 (x86_64-apple-darwin12.0) libcurl/7.24.0 OpenSSL/0.9.8| zlib/1.2.5
  > Host: localhost:9443
  > Accept: /
  > Content-Type: application/json
  >
  < HTTP/1.1 200 OK
  < Date: Tue, 24 Mar 2015 05:54:43 GMT
  < Content-Type: application/json
  < Transfer-Encoding: chunked
  < Server: WSO2 Carbon Server
  <
• Connection #0 to host localhost left intact {"statusCode":200,"successMessage":"Service Group deleted successfully: [service-group] group6"}

  * Closing connection #0

• SSLv3, TLS alert, Client hello (1):

------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
(3) When deleting a cartridge group that does not exist, the HTTP status code 400 is returned [2]. This is incorrect and it should be changed to 404, which is used in not found situations.

HTTP Output - [2]
Admin16s-MacBook-Air:samples Admin16$ curl -X DELETE -H "Content-Type: application/json" -k -v -u admin:admin https://localhost:9443/api/cartridgeGroups/group634

• About to connect() to localhost port 9443 (#0)
• Trying ::1...
• connected
• Connected to localhost (::1) port 9443 (#0)
• SSLv3, TLS handshake, Client hello (1):
• SSLv3, TLS handshake, Server hello (2):
• SSLv3, TLS handshake, CERT (11):
• SSLv3, TLS handshake, Server key exchange (12):
• SSLv3, TLS handshake, Server finished (14):
• SSLv3, TLS handshake, Client key exchange (16):
• SSLv3, TLS change cipher, Client hello (1):
• SSLv3, TLS handshake, Finished (20):
• SSLv3, TLS change cipher, Client hello (1):
• SSLv3, TLS handshake, Finished (20):
• SSL connection using DHE-RSA-AES256-SHA
• Server certificate:
• subject: C=US; ST=CA; L=Mountain View; O=WSO2; CN=localhost
• start date: 2010-02-19 07:02:26 GMT
• expire date: 2035-02-13 07:02:26 GMT
• common name: localhost (matched)
• issuer: C=US; ST=CA; L=Mountain View; O=WSO2; CN=localhost
• SSL certificate verify result: unable to get local issuer certificate (20), continuing anyway.
• Server auth using Basic with user 'admin'
  > DELETE /api/cartridgeGroups/group634 HTTP/1.1
  > Authorization: Basic YWRtaW46YWRtaW4=
  > User-Agent: curl/7.24.0 (x86_64-apple-darwin12.0) libcurl/7.24.0 OpenSSL/0.9.8| zlib/1.2.5
  > Host: localhost:9443
  > Accept: /
  > Content-Type: application/json
  >
  < HTTP/1.1 400 Bad Request
  < Date: Tue, 24 Mar 2015 04:25:16 GMT
  < Content-Type: application/json
  < Transfer-Encoding: chunked
  < Connection: close
  < Server: WSO2 Carbon Server
  <
• Closing connection #0
• SSLv3, TLS alert, Client hello (1): {"errorCode":400,"errorMessage":"Error while fulfilling the request"}

  Admin16s-MacBook-Air:samples Admin16$

Issue Links

• is a clone of: STRATOS-1263 Wrong HTTP status code returned - DELETE /users/{userName}