[STR-2893] FormTag doesn't render the focus javascript compliant with xhtml

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.2 Family
• Fix Version/s: 1.3.12, 1.4.0
• Component/s: Tag Libraries
• Environment: Windows XP SP2, IBM Think Centre
• Flags: Patch
• Assignee: Paul Benedict
• Reporter: Tedy Marcos Colombini
• Created: 22/Jun/06 21:56
• Updated: 25/Nov/09 04:03
• Resolved: 18/Sep/09 06:02

Description

Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:

// xhtml script content shouldn't use the browser hiding trick
if (!this.isXhtml())

{ results.append(" <!--"); results.append(lineEnd); }

I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?

Also, the following snippet doesn't need the !this.isXhtml() check...

if (!this.isXhtml() && this.scriptLanguage)

{ results.append(" language=\"JavaScript\""); }

Regards, Tedy.

Issue Links

• is related to: STR-2232 html:form focus generates non-XHTML