[STR-2809] ImportAttribute does not import all attribute with ignore=true

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.8
• Fix Version/s: 1.3.3
• Component/s: Tiles 1 Plugin
• Environment: Operating System: other; Platform: Other
• Bugzilla Id: 39084
• Assignee: Donald J. Brown
• Reporter: Andrzej Turowski
• Created: 24/Mar/06 00:49
• Updated: 04/Jul/07 03:36
• Resolved: 07/May/06 13:08

Description

If we have a list of attribute and a null value is encountered SKIP_BODY is
returned and other attributes are not imported into the pageContext.
I think we need to take out the else clause?

public int doStartTag() throws JspException
....
....

if( value == null )

{ if(!isErrorIgnored) throw new JspException ( "Error - tag importAttribute : property '"+ name + "' has a value of 'null'" ); else return SKIP_BODY; }

should become

if( value == null )

{ if(!isErrorIgnored) throw new JspException ( "Error - tag importAttribute : property '"+ name + "' has a value of 'null'" ); }