[STR-2270] "created" boolean in FacesRequestProcessor.doForward() not being set

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.4
• Fix Version/s: 1.2 Family
• Component/s: JSF Integration (Dormant)
• Environment: Operating System: All; Platform: All
• Bugzilla Id: 32047
• Assignee: Unassigned
• Reporter: Chris Fraser
• Created: 04/Nov/04 04:41
• Updated: 16/Feb/11 19:52
• Resolved: 04/Jul/07 05:30

Description

In the doForward method of latest version of FacesRequestProcessor, you
introduced a boolean, "created", which is used to determine whether or not
context.release() should be called. In theory this should work great. However,
"created" never gets set to anything but false, and therefore context.release()
never gets called. I'm not sure if anyone's actually using this code, because
for me, this results in my app blowing wide open.

Another thing to note is in the block of code just after
FacesContext.getCurrentInstance() gets called. The context is being set twice
in this case. Once using the HttpServletRequestWrapper and then immediately
after using the HttpServletRequest. From the comments it appears that then 2nd
one is intended to be commented out.

Here's the source that I'm looking at:
http://svn.apache.org/viewcvs.cgi/struts/trunk/struts-faces/core-library/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java

Thanks for your help, and keep up the good work.

• Chris Fraser