[STR-2245] Modify Action.getErrors to save the new ActionMessages

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 1.2.4
• Component/s: Extras
• Environment: Operating System: All; Platform: All
• Bugzilla Id: 31729
• Assignee: Unassigned
• Reporter: richard.beton
• Created: 15/Oct/04 21:41
• Updated: 16/Feb/11 19:44
• Resolved: 04/Jul/07 05:30

Description

org.apache.struts.action.Action contains

protected ActionMessages getErrors(HttpServletRequest request) {
ActionMessages errors =
(ActionMessages) request.getAttribute(Globals.ERROR_KEY);
if (errors == null)

{ errors = new ActionMessages(); }

return errors;
}

It may be considered more robust if the new messages object was always placed
in the request attribute thusly:

protected ActionMessages getErrors(HttpServletRequest request) {
ActionMessages errors =
(ActionMessages) request.getAttribute(Globals.ERROR_KEY);
if (errors == null)

{ errors = new ActionMessages(); request.setAttribute(Globals.ERROR_KEY, errors); }

return errors;
}