[STR-1634] <tiles:insert> should pass flush attribute to JspWriter

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.3.0
• Component/s: Tiles 1 Plugin
• Environment: Operating System: other; Platform: All
• Bugzilla Id: 21972
• Assignee: Donald J. Brown
• Reporter: Fabricio Voznika
• Created: 29/Jul/03 22:38
• Updated: 26/Apr/06 01:58
• Resolved: 26/Apr/06 01:58

Description

Let's suppose I do a
<titles:insert page="/template_main.jsp" flush="false">
...

When the code is executed, the method InsertHandler.doEndTag() (inner of
InsertTag) is called. In the end, before all catches (line 881), after correctly
testing for flush, doInclude() is called. It then calls TilesUtil.doInclude(),
that calls TilesUtilImpl.doInclude(), that calls PageContext.include(String).
According to the documentation (see bellow), this last method flushes the JspWriter.

"The current JspWriter "out" for this JSP is flushed as a side-effect of this
call, prior to processing the include."

The flush variable should be propagated to TilesUtilImpl.doInclude(), and
PageContext.include(String, boolean) called.

Always flushing, makes setting response headers, forwarding and error handling
(forwarding) impossible to use together with tile.