[STORM-966] ConfigValidation.DoubleValidator doesn't really validate whether the type of the object is a double

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: storm-core
• Assignee: Boyang Jerry Peng
• Reporter: Boyang Jerry Peng
• Created: 29/Jul/15 21:08
• Updated: 30/Sep/15 01:05
• Resolved: 06/Aug/15 02:19

Description

ConfigValidation.DoubleValidator code only checks if the object is null whether if the object is a instance of Number which is a parent class of Double.

DoubleValidator is only used once in Config.java and in that instance:

public static final Object TOPOLOGY_STATS_SAMPLE_RATE_SCHEMA = ConfigValidation.DoubleValidator;

can just be set to:

public static final Object TOPOLOGY_STATS_SAMPLE_RATE_SCHEMA = NUMBER.class;

Then we can just get rid of the misleading function ConfigValidation.DoubleValidator since it doesn't really check if a object is of double type thus the validator function doesn't really do anything and the name is misleading. In previous commit https://github.com/apache/storm/commit/214ee7454548b884c591991b1faea770d1478cec Number.Class was used anyway