[STORM-3938] Unhandled InterruptedException in Supervisor's close() method

• Type: Improvement
• Status: Closed
• Priority: Blocker
• Resolution: Won't Fix
• Affects Version/s: 2.4.0
• Component/s: storm-server
• Flags: Patch, Important
• External issue URL: https://github.com/apache/storm/pull/3554
• Assignee: Richard Zowalla
• Reporter: LoggingResearch
• Created: 22/Jul/23 08:15
• Updated: 09/Nov/23 12:51
• Resolved: 09/Nov/23 12:51

Description

In the Supervisor class's close() method, we are attempting to close the asyncLocalizer object which can throw an InterruptedException. However, currently, the InterruptedException thrown by asyncLocalizer.close() is not being caught or logged. This is an issue because InterruptedException is a more specific exception that might need to be handled separately from the general Exception catch block.

This can lead to a situation where if an InterruptedException is thrown, we will not have any log information about it, making it difficult to debug the issue.

Proposed solution:

Add a separate catch block for InterruptedException before the general Exception catch block to handle and log the InterruptedException properly.

https://github.com/apache/storm/pull/3554