[STORM-3699] fix flight.bash to support flight recording on openJDK8u262 or newer

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0, 2.1.0, 2.2.0
• Fix Version/s: 2.3.0
• Assignee: Ethan Li
• Reporter: Ethan Li
• Created: 15/Sep/20 20:32
• Updated: 18/Sep/20 15:01
• Resolved: 18/Sep/20 15:01

Description

https://docs.oracle.com/javacomponents/jmc-5-4/jfr-runtime-guide/comline.htm#JFRUH193

https://docs.oracle.com/javacomponents/jmc-5-5/jfr-command-reference/diagnostic-command-reference.htm#resourceid-15422-48C8362C

 

flight recorder command changed between versions. so the current flight.bash doesn't work for flight recording on newer JFR version (e.g. on openJDK8u262)

https://github.com/apache/storm/blob/eb27556f7669c7c966716e1aca4867da04ce6e08/bin/flight.bash#L86-L93

 

bash-4.2$ java -version
openjdk version "1.8.0_262"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_262-b10)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.262-b10, mixed mode)
bash-4.2$ jcmd 20 JFR.stop recording=1
20:
java.lang.IllegalArgumentException: Unknown argument 'recording' in diagnostic command.