Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3654

JCQueue shouldn't include executor string in the metric name

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0
    • Component/s: storm-client
    • Labels:
      None

      Description

      I noticed that the JCQueue metrics have names like

      receive-queue_65__65_-capacity
      receive-queue_65__65_-population
      receive-queue_100__100_-capacity
      receive-queue_100__100_-population
      ..
      

      This is not suitable for aggregation. We shouldn't include executors in the metric name.

      https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java#L682

       

        Attachments

          Activity

            People

            • Assignee:
              li530 Rui Li
              Reporter:
              li530 Rui Li

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                  Issue deployment