Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3604

HealthChecker should print out error message when it fails

Rank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 2.2.0
    • None

    Description

      Currently in the code https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java#L122-L130

                 if (process.exitValue() != 0) {
                      String str;
                      InputStream stdin = process.getInputStream();
                      BufferedReader reader = new BufferedReader(new InputStreamReader(stdin));
                      while ((str = reader.readLine()) != null) {
                          if (str.startsWith("ERROR")) {
                              LOG.warn("The healthcheck process {} exited with code {}", script, process.exitValue());
                              return FAILED;
                          }
                      }
                      return FAILED_WITH_EXIT_CODE;
                  }
      

      The healthcheck doesn't really print out the error message so it's not easy to debug when healthcheck fails.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ethanli Ethan Li
            ethanli Ethan Li
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                Slack

                  Issue deployment