[STORM-3589] Iterator in BaseResourceStrategy is potentially buggy

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0, 2.1.0
• Fix Version/s: 2.2.0
• Labels: pull-request-available
• Assignee: Rui Li
• Reporter: Rui Li
• Created: 24/Feb/20 15:04
• Updated: 01/Jul/20 14:08
• Resolved: 27/Feb/20 14:57

Description

https://github.com/apache/storm/blame/master/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java#L280

We should probably only peek but not remove value from nodeIterator in hasNext() function.

 

https://github.com/apache/storm/blame/master/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java#L296-L300

 

And two consecutive next() call will cause problem.

Issue Links

• links to: GitHub Pull Request #3216