[STORM-3552] Storm CLI set_log_level no longer updates the log level

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0, 2.1.0
• Fix Version/s: 2.2.0, 2.1.1
• Component/s: storm-core
• Labels: pull-request-available
• Assignee: Luke Marjoram
• Reporter: Luke Marjoram
• Created: 09/Dec/19 16:33
• Updated: 03/Jan/20 06:24
• Resolved: 03/Jan/20 06:24

Description

Using the example StatefulWindowingTopology, when trying to update the log level via command line with the following command a NullPointer is thrown in the worker log and the log level is not updated.

storm set_log_level -l ROOT=DEBUG:0 test

2019-12-09 17:16:02.600+0100 o.a.s.s.o.a.c.f.i.CuratorFrameworkImpl main-EventThread [ERROR] Event listener threw exception
java.lang.NullPointerException: null
        at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936) ~[?:1.8.0_131]
        at org.apache.logging.log4j.Level.getLevel(Level.java:261) ~[log4j-api-2.11.2.jar:2.11.2]
        at org.apache.storm.daemon.worker.LogConfigManager.setLoggerLevel(LogConfigManager.java:145) ~[storm-client-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.daemon.worker.LogConfigManager.processLogConfigChange(LogConfigManager.java:98) ~[storm-client-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.daemon.worker.Worker.checkLogConfigChanged(Worker.java:422) ~[storm-client-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.cluster.StormClusterStateImpl.issueMapCallback(StormClusterStateImpl.java:177) ~[storm-client-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.cluster.StormClusterStateImpl$1.changed(StormClusterStateImpl.java:122) ~[storm-client-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.cluster.ZKStateStorage$ZkWatcherCallBack.execute(ZKStateStorage.java:243) ~[storm-client-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.zookeeper.ClientZookeeper.lambda$mkClientImpl$0(ClientZookeeper.java:314) ~[storm-client-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.curator.framework.imps.CuratorFrameworkImpl$7.apply(CuratorFrameworkImpl.java:1048) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.curator.framework.imps.CuratorFrameworkImpl$7.apply(CuratorFrameworkImpl.java:1041) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.curator.framework.imps.CuratorFrameworkImpl.processEvent(CuratorFrameworkImpl.java:1040) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.curator.framework.imps.CuratorFrameworkImpl.access$000(CuratorFrameworkImpl.java:66) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.curator.framework.imps.CuratorFrameworkImpl$1.process(CuratorFrameworkImpl.java:126) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.curator.ConnectionState.process(ConnectionState.java:185) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:533) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]
        at org.apache.storm.shade.org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:508) [storm-shaded-deps-2.1.0.jar:2.1.1-SNAPSHOT]

This appears to be a regression from the migration from clojure to java in STORM-1267

Issue Links

• links to: GitHub Pull Request #3181
• links to: GitHub Pull Request #3182