Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3529

Catch and log RetriableException in KafkaOffsetMetric

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      When the KafkaOffsetMetric.getValueAndReset method calls the KafkaClient methods, exceptions may be thrown. When these exceptions are retriable, we should not crash the worker by letting them escape the method. We should instead catch and log the exception.

      An example of the desired behavior can be seen at https://github.com/apache/storm/blob/7b1a98fc10fad516ef9ed0b3afc53a1d7be8a169/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java#L295

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            olivermd Oliver Downard
            srdo Stig Rohde Døssing
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 10m
                1h 10m

                Slack

                  Issue deployment