[STORM-3529] Catch and log RetriableException in KafkaOffsetMetric

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.2.0
• Component/s: storm-kafka-client
• Labels: newbie pull-request-available
• Assignee: Oliver Downard
• Reporter: Stig Rohde Døssing
• Created: 25/Oct/19 22:56
• Updated: 01/Jul/20 14:07
• Resolved: 13/Nov/19 15:59

Description

When the KafkaOffsetMetric.getValueAndReset method calls the KafkaClient methods, exceptions may be thrown. When these exceptions are retriable, we should not crash the worker by letting them escape the method. We should instead catch and log the exception.

An example of the desired behavior can be seen at https://github.com/apache/storm/blob/7b1a98fc10fad516ef9ed0b3afc53a1d7be8a169/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java#L295

Issue Links

• links to: GitHub Pull Request #3164