Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3491

BoltReaderRunnable shouldn't throw IllegalArgumentException for sync command

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0
    • Fix Version/s: 2.1.0
    • Component/s: None

      Description

      So I was preparing for a new release candidate i.e. rc3. I can build it from source without any problem. Then I set up a standalone cluster and submitted a WordCountTopology. The workers kept restarting because of

      2019-08-19 15:09:49.635 o.a.s.t.ShellBolt Thread-30 [ERROR] Halting process: ShellBolt died. Command: [python, splitsentence.py], ProcessInfo pid:3756, name:split exitCode:-1, errorString:
      java.lang.IllegalArgumentException: command sync is not supported
              at org.apache.storm.task.ShellBolt$BoltReaderRunnable.run(ShellBolt.java:366) [storm-client-2.1.0.jar:2.1.0]
              at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]
      2019-08-19 15:09:49.635 o.a.s.e.e.ReportError Thread-30 [ERROR] Error
      java.lang.IllegalArgumentException: command sync is not supported
              at org.apache.storm.task.ShellBolt$BoltReaderRunnable.run(ShellBolt.java:366) [storm-client-2.1.0.jar:2.1.0]
              at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]
      2019-08-19 15:09:49.636 o.a.s.t.ShellBolt Thread-28 [ERROR] Halting process: ShellBolt died. Command: [python, splitsentence.py], ProcessInfo pid:3755, name:split exitCode:-1, errorString:
      java.lang.IllegalArgumentException: command sync is not supported
              at org.apache.storm.task.ShellBolt$BoltReaderRunnable.run(ShellBolt.java:366) [storm-client-2.1.0.jar:2.1.0]
              at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]
      2019-08-19 15:09:49.637 o.a.s.e.e.ReportError Thread-28 [ERROR] Error
      java.lang.IllegalArgumentException: command sync is not supported
              at org.apache.storm.task.ShellBolt$BoltReaderRunnable.run(ShellBolt.java:366) [storm-client-2.1.0.jar:2.1.0]
              at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]
      

      https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/task/ShellBolt.java#L365-L367 I believe we shouldn’t throw exceptions here.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ethanli Ethan Li
                Reporter:
                ethanli Ethan Li
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h