[STORM-3472] STORM-3411 should have tests, and we shouldn't catch NPE for control flow

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.1.0
• Component/s: storm-webapp
• Labels: pull-request-available
• Assignee: Stig Rohde Døssing
• Reporter: Stig Rohde Døssing
• Created: 21/Jul/19 17:17
• Updated: 10/Aug/19 22:13
• Resolved: 26/Jul/19 16:40

Description

I think the code merged in STORM-3411 should have added tests that the new functionality works.

We should get rid of the new bit of code that try-catches an NPE to check whether the downloaded file is inside a worker dir. Instead, we should move the name generation up the call hierarchy to a place where we can tell whether we're inside a worker dir or not.

Issue Links

• links to: GitHub Pull Request #3091