[STORM-3376] Storm drops messages in the interval between server bind and callback registration

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.1.0
• Component/s: storm-client
• Labels: pull-request-available
• Assignee: Stig Rohde Døssing
• Reporter: Stig Rohde Døssing
• Created: 12/Apr/19 18:24
• Updated: 10/Aug/19 22:24
• Resolved: 05/May/19 14:14

Description

This is one of the causes of unstable integration tests.

When a worker starts, WorkerState boots up a Server, which binds Netty to a port in order to receive messages from other workers. Slightly later, we register a callback with the server that defines where the Server should deliver received messages.

In the interim between binding the port and registering the callbacks, Storm quietly discards any received messages.

Other workers will happily send messages to the worker that is not ready, as the sending side considers an open connection to be sufficient to send messages.

We should change the setup so we set the receive callback before we start the Server.

Issue Links

• links to: GitHub Pull Request #2996