[STORM-3292] Trident HiveState must flush writers when the batch commits

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0, 1.2.3
• Labels: pull-request-available
• Assignee: Arun Mahadevan
• Reporter: Arun Mahadevan
• Created: 27/Nov/18 02:11
• Updated: 02/Dec/18 07:18
• Resolved: 02/Dec/18 07:18

Description

For trident the hive writer is flushed only after it hits the batch size.

see - https://github.com/apache/storm/blob/master/external/storm-hive/src/main/java/org/apache/storm/hive/trident/HiveState.java#L108

Trident HiveState does not flush during the batch commit and it appears to be an oversight. Without this trident state cannot guarantee at-least once. (E.g. if the transaction is open but trident moves to the next txid and later fails the data in the open transaction is lost).

So I think for at-least once, the HiveState must flush all the writers irrespective of the batch sizes when trident invokes the "commit(txid)" .

Issue Links

• links to: GitHub Pull Request #2916