[STORM-3264] "local variable 'ret' referenced before assignment" in storm.py

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Labels: pull-request-available
• Assignee: Ethan Li
• Reporter: Ethan Li
• Created: 19/Oct/18 21:59
• Updated: 06/Nov/18 16:58
• Resolved: 06/Nov/18 16:58

Description

In https://github.com/apache/storm/blob/master/bin/storm.py#L142

# If given path is a dir, make it a wildcard so the JVM will include all JARs in the directory.
def get_wildcard_dir(path):
    if os.path.isdir(path):
        ret = [(os.path.join(path, "*"))]
    elif os.path.exists(path):
        ret = [path]
    return ret

It's possible to get

  File "/tmp/verify-release/apache-storm-2.0.0/bin/storm.py", line 147, in get_wildcard_dir
    return ret
UnboundLocalError: local variable 'ret' referenced before assignment

because there is no "else" branch.

Issue Links

• links to: GitHub Pull Request #2900