Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3222

Fix KafkaSpout internals to use LinkedList instead of ArrayList

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0, 1.2.2
    • Fix Version/s: 2.0.0, 1.2.3, 1.1.4
    • Component/s: None

      Description

      KafkaSpout internally maintains a waitingToEmit list per topic partition and keeps removing the first item to emit during each nextTuple. The implementation uses an ArrayList which results in un-necessary traversal and copy for each tuple.

      Also I am not sure why the nextTuple only emits a single tuple wheres ideally it should emit whatever it can emit in a single nextTuple call which is more efficient. However the logic appears too complicated to refactor.

        Attachments

          Activity

            People

            • Assignee:
              arunmahadevan Arun Mahadevan
              Reporter:
              arunmahadevan Arun Mahadevan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 3h 10m
                3h 10m