Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3155

IOutputSerializer implementations always allocates a new ByteBuffer

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0.0
    • Fix Version/s: None
    • Component/s: storm-sql
    • Labels:
      None

      Description

      The IOutputSerializer javadoc specifies that the user may optionally provide a ByteBuffer to serialize into.

      https://github.com/apache/storm/blob/af42f434f4a4c3d9087c6058b359033736d3b5e8/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/IOutputSerializer.java#L26

      None of the IOutputSerializer implementations we ship with actually do this. They all ignore the ByteBuffer parameter.

      If this is a useful feature, I think that we should update them to use the supplied ByteBuffer if not null. If it isn't a useful feature, we should instead remove the ByteBuffer parameter from the API.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              Srdo Stig Rohde Døssing
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: