[STORM-3143] Unnecessary inclusion of empty match result in Json

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: storm-webapp
• Labels: pull-request-available
• Assignee: Zhengdai Hu
• Reporter: Zhengdai Hu
• Created: 05/Jul/18 18:43
• Updated: 10/Jul/18 03:51
• Resolved: 10/Jul/18 03:51

Description

`FindNMatches()` didn't correctly filter out empty match result in `substringSearch()` and hence send back an empty map to user. I don't know if this the desired behavior but a fix to current behavior will make metrics for logviewer easier to implement.

An example of current behavior:

{
    "fileOffset": 1,
    "searchString": "sdf",
    "matches": [
        {
            "searchString": "sdf",
            "fileName": "word-count-1-1530815972/6701/worker.log",
            "matches": [],
            "port": "6701",
            "isDaemon": "no",
            "startByteOffset": 0
        }
    ]
}

Desired behavior:

{
    "fileOffset": 1,
    "searchString": "sdf",
    "matches": []
}

Issue Links

• links to: GitHub Pull Request #2753