[STORM-3135] JCQueueTest is flaky

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: storm-client
• Labels: pull-request-available
• Assignee: Stig Rohde Døssing
• Reporter: Stig Rohde Døssing
• Created: 29/Jun/18 20:41
• Updated: 10/Jul/18 22:49
• Resolved: 10/Jul/18 22:49

Description

Saw the JCQueueTest fail a couple of times on Travis.

testFirstMessageFirst(org.apache.storm.utils.JCQueueTest)  Time elapsed: 0.86 sec  <<< FAILURE!
java.lang.AssertionError: Unable to send halt interrupt
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.apache.storm.utils.JCQueueTest.run(JCQueueTest.java:151)
	at org.apache.storm.utils.JCQueueTest.run(JCQueueTest.java:127)
	at org.apache.storm.utils.JCQueueTest.testFirstMessageFirst(JCQueueTest.java:61)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)

I think we should just keep trying to send the interrupt until we succeed, or we hit a reasonable timeout.

Issue Links

• links to: GitHub Pull Request #2745