[STORM-3101] Fix unexpected metrics registration in StormMetricsRegistry

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.0.0
• Component/s: storm-server
• Labels: pull-request-available
• Assignee: Zhengdai Hu
• Reporter: Zhengdai Hu
• Created: 12/Jun/18 20:39
• Updated: 01/Jun/19 09:10
• Resolved: 01/Jun/19 09:10

Description

Metrics that are registered using StormMetricRegistry all added through static method from the registry class, and attached to a singleton MetricRegistry object per process. Currently most metrics are bound to classes (static), so the issue occurs when metrics from irrelevant components are accidentally registered in class initialization phase.

For example, a process running supervisor daemon will incorrectly register metrics from nimbus when BasicContainer class is initialized and statically imports "org.apache.storm.daemon.nimbus.Nimbus.MIN_VERSION_SUPPORT_RPC_HEARTBEAT", which triggers initialization of Nimbus class and all metrics registration, even though no functionalities of nimbus daemon will be used and no nimbus metrics will be updated.

This creates many garbage metrics and makes metrics hard to read. Therefore we should filter metrics registration by the type of daemon that the process actually runs.

For implementation please see the pull request.

Issue Links

• Is contained by: STORM-3197 Make StormMetricsRegistry a regular instance class rather than a static utility
• links to: GitHub Pull Request #2714
• links to: GitHub Pull Request #2714