[STORM-3064] PartitionedTridentSpoutExecutor should use getPartitionsForTask

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: storm-client
• Labels: pull-request-available
• Assignee: Jing Chen
• Reporter: Stig Rohde Døssing
• Created: 09/May/18 10:34
• Updated: 22/Jun/18 14:04
• Resolved: 22/Jun/18 14:04

Description

https://issues.apache.org/jira/browse/STORM-2407 added a method to the IOpaquePartitionedTridentSpout.Emitter interface called getPartitionsForTask, which is now used to delegate partitioning between tasks (previously, the partitioning was hard coded to round robin).

If we want to be able to delegate partitioning, I don't see a reason not to make the same change on the IPartitionedTridentSpout.Emitter interface, where partitioning is still hard coded to use round robin. E.g. compare https://github.com/apache/storm/blob/4137328b75c06771f84414c3c2113e2d1c757c08/storm-client/src/jvm/org/apache/storm/trident/spout/PartitionedTridentSpoutExecutor.java#L131 to https://github.com/apache/storm/blob/4137328b75c06771f84414c3c2113e2d1c757c08/storm-client/src/jvm/org/apache/storm/trident/spout/OpaquePartitionedTridentSpoutExecutor.java#L131

Issue Links

• links to: GitHub Pull Request #2729