[STORM-3048] A Potential NPE

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Labels: pull-request-available
• Assignee: lujie
• Reporter: lujie
• Created: 30/Apr/18 11:43
• Updated: 03/Jun/18 06:50
• Resolved: 03/Jun/18 06:50

Description

We have developed a static analysis tool NPEDetector to find some potential NPE. Our analysis shows that some callees may return null in corner case(e.g. node crash , IO exception), some of their callers have  !=null check but some do not have. 

Bug:

Cluster#getAssignmentById has 20 callers, 18 callers have null checker like this:

SchedulerAssignment assignment = cluster.getAssignmentById(td.getId());
if (assignment != null) {
    cpuNeeded -= getCpuUsed(assignment);
     memoryNeeded -= getMemoryUsed(assignment);
}

the caller have no null checker :ConstraintSolverStrategy#checkSpreadSchedulingValid ConstraintSolverStrategy#checkConstraintsSatisfied.

Issue Links

• links to: GitHub Pull Request #2657