[STORM-2834] getOwnerResourceSummaries not working properly because scheduler is wrapped as BlacklistScheduler

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Labels: pull-request-available
• Assignee: Ethan Li
• Reporter: Ethan Li
• Created: 28/Nov/17 19:05
• Updated: 05/Dec/17 07:29
• Resolved: 05/Dec/17 07:29

Description

https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L4101

 if (clusterSchedulerConfig.containsKey(theOwner)) {
                    if (scheduler instanceof ResourceAwareScheduler) {
                        Map<String, Object> schedulerConfig = (Map) clusterSchedulerConfig.get(theOwner);
                        if (schedulerConfig != null) {
                            ownerResourceSummary.set_memory_guarantee((double)schedulerConfig.getOrDefault("memory", 0));
                            ownerResourceSummary.set_cpu_guarantee((double)schedulerConfig.getOrDefault("cpu", 0));
                            ownerResourceSummary.set_memory_guarantee_remaining(ownerResourceSummary.get_memory_guarantee()
                                    - ownerResourceSummary.get_memory_usage());
                            ownerResourceSummary.set_cpu_guarantee_remaining(ownerResourceSummary.get_cpu_guarantee()
                                    - ownerResourceSummary.get_cpu_usage());
                        }
                    } else if (scheduler instanceof  MultitenantScheduler) {
                        ownerResourceSummary.set_isolated_node_guarantee((int) clusterSchedulerConfig.getOrDefault(theOwner, 0));
                    }
                }

Because scheduler is wrapped as BlackListScheduler (https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L474), these two "instanceof" will never be true.

Issue Links

• links to: GitHub Pull Request #2437