[STORM-2826] KafkaSpoutConfig.builder doesn't set key/value deserializer properties in storm-kafka-client

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 1.2.0
• Component/s: storm-kafka-client
• Labels: pull-request-available
• Epic Link: Release Apache Storm 1.2.0
• Assignee: Stig Rohde Døssing
• Reporter: Stig Rohde Døssing
• Created: 19/Nov/17 15:41
• Updated: 16/Dec/17 00:03
• Resolved: 16/Dec/17 00:03

Description

STORM-2548 replaced the KafkaSpoutConfig.builder() implementations with ones that don't set the key/value deserializer fields in KafkaSpoutConfig, but instead just sets the corresponding property in the kafkaProps map. This is a breaking change for applications that assume those properties are set after the builder is created.

Code like the following would break.

this.keyDeserializer = config.getKeyDeserializer().getClass();
this.valueDeserializer = config.getValueDeserializer().getClass();

Issue Links

• links to: GitHub Pull Request #2428