Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-2503

lgtm.com alerts: bugs in equality and comparison operations

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 1.1.1, 1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      There are a number of alerts found by lgtm.com at https://lgtm.com/projects/g/apache/storm/alerts/ that indicate genuine bugs in comparison operations in the Storm code.

      These rules include:

      • Equals on incomparable types (leading to bugs in comparison or caching)
      • Hashed value without hashCode definition
      • Inconsistent equals and hashCode (together with the previous one, this indicates some missing hashCode implementations)
      • Comparison of identical values (indicating incorrect comparator logic in DefaultResourceAwareStrategy)
      • Useless comparison test (indicating a variable name typo)
      • Suspicious reference equality test of boxed types (indicating a spurious use of == instead of equals on boxed types)

        Attachments

          Activity

            People

            • Assignee:
              adityasharad Aditya Sharad
              Reporter:
              adityasharad Aditya Sharad
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 5h 10m
                5h 10m