[STORM-2503] lgtm.com alerts: bugs in equality and comparison operations

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0, 1.1.1, 1.2.0
• Assignee: Aditya Sharad
• Reporter: Aditya Sharad
• Created: 04/May/17 19:42
• Updated: 09/Jul/17 01:57
• Resolved: 02/Jun/17 15:38

Description

There are a number of alerts found by lgtm.com at https://lgtm.com/projects/g/apache/storm/alerts/ that indicate genuine bugs in comparison operations in the Storm code.

These rules include:

• Equals on incomparable types (leading to bugs in comparison or caching)
• Hashed value without hashCode definition
• Inconsistent equals and hashCode (together with the previous one, this indicates some missing hashCode implementations)
• Comparison of identical values (indicating incorrect comparator logic in DefaultResourceAwareStrategy)
• Useless comparison test (indicating a variable name typo)
• Suspicious reference equality test of boxed types (indicating a spurious use of == instead of equals on boxed types)

Issue Links

• links to: GitHub Pull Request #2100
• links to: GitHub Pull Request #2143
• links to: GitHub Pull Request #2149