[STORM-2386] Fail-back Blob deletion also fails in BlobSynchronizer.syncBlobs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0, 1.1.0, 1.0.3
• Fix Version/s: 2.0.0, 1.1.0, 1.0.4
• Component/s: storm-core
• Assignee: Jungtaek Lim
• Reporter: Jungtaek Lim
• Created: 28/Feb/17 02:59
• Updated: 04/Mar/17 02:23
• Resolved: 04/Mar/17 02:23

Description

This is a bug introduced from STORM-2321.

            for (String key : keySetToDownload) {
                try {
                    Set<NimbusInfo> nimbusInfoSet = BlobStoreUtils.getNimbodesWithLatestSequenceNumberOfBlob(zkClient, key);
                    if (BlobStoreUtils.downloadMissingBlob(conf, blobStore, key, nimbusInfoSet)) {
                        BlobStoreUtils.createStateInZookeeper(conf, key, nimbusInfo);
                    }
                } catch (KeyNotFoundException e) {
                    LOG.debug("Detected deletion for the key {} - deleting the blob instead", key);
                    // race condition with a delete, delete the blob in key instead
                    blobStore.deleteBlob(key, BlobStoreUtils.getNimbusSubject());
                }
            }

'keySetToDownload' are keys which exist in Zookeeper, and do not exist in local. So deleting blob in local doesn't make sense. (Seems like I was confused at that time.)

if downloading throws KeyNotFoundException, it means that the blob is not available neither Zookeeper nor local, so just skipping would be OK.

Issue Links

• links to: GitHub Pull Request #1975
• links to: GitHub Pull Request #1976