[STORM-2358] Update storm hdfs spout to remove specific implementation handlings

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Abandoned
• Affects Version/s: 1.x
• Component/s: storm-hdfs
• Labels: newbie pull-request-available
• Assignee: Unassigned
• Reporter: Sachin Pasalkar
• Created: 14/Feb/17 02:01
• Updated: 02/Jul/24 09:54
• Resolved: 02/Jul/24 09:54

Description

I was looking at storm hdfs spout code in 1.x branch, I found below
improvements can be made in below code.

1. Make org.apache.storm.hdfs.spout.AbstractFileReader as public so
that it can be used in generics.

2. org.apache.storm.hdfs.spout.HdfsSpout requires readerType as
String. It will be great to have class<? extends AbstractFileReader>
readerType; So we will not use Class.forName at multiple places also it
will help in below point.

3. HdfsSpout also needs to provide outFields which are declared as
constants in each reader(e.g.SequenceFileReader). We can have abstract
API AbstractFileReader in which return them to user to make it generic.

Issue Links

• links to: GitHub Pull Request #1942