Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-2338

Subprocess exception handling is broken in storm.py on Windows environment

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0, 1.x, 0.10.3
    • Fix Version/s: 2.0.0, 1.1.0, 1.0.3
    • Component/s: storm-core
    • Labels:
      None

      Description

      There is typo in the exception handling branch in storm.py:: exec_storm_class():

              try:
                  ret = sub.check_output(all_args, stderr=sub.STDOUT)
                  print(ret)
              except sub.CalledProcessor as e:
                  sys.exit(e.returncode)
      

      There is no "CalledProcessor" type of exception exists in subprocess module.
      The correct exception name is CalledProcessError.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                tibor.kiss@gmail.com Tibor Kiss
                Reporter:
                tibor.kiss@gmail.com Tibor Kiss
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h