[STORM-2338] Subprocess exception handling is broken in storm.py on Windows environment

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0, 1.x, 0.10.3
• Fix Version/s: 2.0.0, 1.1.0, 1.0.3
• Component/s: storm-core
• Assignee: Tibor Kiss
• Reporter: Tibor Kiss
• Created: 03/Feb/17 08:09
• Updated: 07/Feb/17 05:13
• Resolved: 07/Feb/17 02:29

Description

There is typo in the exception handling branch in storm.py:: exec_storm_class():

        try:
            ret = sub.check_output(all_args, stderr=sub.STDOUT)
            print(ret)
        except sub.CalledProcessor as e:
            sys.exit(e.returncode)

There is no "CalledProcessor" type of exception exists in subprocess module.
The correct exception name is CalledProcessError.

Issue Links

• links to: GitHub Pull Request #1917