Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-2324

Topology should not fail if topology jar is missing resources directory

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 1.1.0, 1.0.3
    • Component/s: None
    • Labels:
      None

      Description

      Since Storm 1.0, due to STORM-876,
      When the topo jar does not contain a resources directory, the topology fails if

      supervisor.run.worker.as.user : true
      

      Assessment:
      After unpacking the topo jar file, supervisor.clj establishes a symlink to the resources directory without checking if the topology jar actually had a resources directory. This leads to a broken symlink.

      Subsequently when the worker-launcher tool runs and tries to chmod the resources dir, it fails. This stalls the topology execution.

      2017-01-17 15:48:12.413 o.a.s.d.supervisor [INFO] Running as user:xyz-admin command:("/usr/hdp/2.5.3.0-37/storm/bin/worker-launcher" "xyz-admin" "worker" "/apps/hadoop/storm/workers/46911423-af41-4db3-8480-7a95df96632a" "/apps/hadoop/storm/workers/46911423-af41-4db3-8480-7a95df96632a/storm-worker-script.sh")
      2017-01-17 15:48:12.417 o.a.s.d.supervisor [INFO] 46911423-af41-4db3-8480-7a95df96632a still hasn't started
      2017-01-17 15:48:12.418 o.a.s.util [WARN] Worker Process 46911423-af41-4db3-8480-7a95df96632a:main : command provided worker
      2017-01-17 15:48:12.426 o.a.s.util [WARN] Worker Process 46911423-af41-4db3-8480-7a95df96632a:main : user is xyz-admin
      2017-01-17 15:48:12.426 o.a.s.util [WARN] Worker Process 46911423-af41-4db3-8480-7a95df96632a:Failure to exec app initialization process - No such file or directory
      

        Issue Links

          Activity

          Show
          roshan_naik Roshan Naik added a comment - PR: https://github.com/apache/storm/pull/1898
          Hide
          kabhwan Jungtaek Lim added a comment -

          Thanks Roshan Naik, I merged into master and 1.x branch.
          I'll port back this to 1.0.x branch after 1.0.3 RC1 vote ends.

          Show
          kabhwan Jungtaek Lim added a comment - Thanks Roshan Naik , I merged into master and 1.x branch. I'll port back this to 1.0.x branch after 1.0.3 RC1 vote ends.

            People

            • Assignee:
              roshan_naik Roshan Naik
              Reporter:
              roshan_naik Roshan Naik
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 50m
                50m

                  Development