[STORM-2234] heartBeatExecutorService in shellSpout don't work well with deactivate

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.x, 0.10.3
• Fix Version/s: 2.0.0, 1.1.0, 1.0.3
• Component/s: storm-core
• Labels: bug
• Environment: Irrelevant - all
• Assignee: itiel
• Reporter: itiel
• Created: 03/Dec/16 16:26
• Updated: 06/Dec/16 23:24
• Resolved: 06/Dec/16 23:24

Description

When using the activate and deactivate of a shellSpout (using the client):
1 .First we deactivate -which calls :

heartBeatExecutorService.shutdownNow();

2. Then we actiavate which calls:

heartBeatExecutorService.scheduleAtFixedRate(new SpoutHeartbeatTimerTask(this), 1, 1, TimeUnit.SECONDS);

3.This results in an

RejectedExecutionException

as we already shutdown the heartBeatExecutorService.
4.Simple test to prove this:

    
private class TestTimerTask extends TimerTask {


        @Override
        public void run() {
            System.out.println("Im running now");
        }
    }

    @Test(expectedExceptions = RejectedExecutionException.class)
    public void heartBeatShutdownTest() {
        ScheduledExecutorService heartBeatExecutorService = MoreExecutors.getExitingScheduledExecutorService(new ScheduledThreadPoolExecutor(1));
        heartBeatExecutorService.scheduleAtFixedRate(new TestTimerTask(), 1, 1, TimeUnit.SECONDS);
        heartBeatExecutorService.shutdownNow();
        heartBeatExecutorService.scheduleAtFixedRate(new TestTimerTask(), 1, 1, TimeUnit.SECONDS);
    }

5.Already created a fix and opening a PR with it: https://github.com/apache/storm/pull/1813

Issue Links

• links to: GitHub Pull Request #1813