[STORM-2121] StringKeyValueScheme doesn't override getOutputFields()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Abandoned
• Component/s: storm-kafka
• Assignee: Unassigned
• Reporter: Andreas Maier
• Created: 23/Sep/16 13:47
• Updated: 02/Jul/24 09:54
• Resolved: 02/Jul/24 09:54

Description

In org.apache.storm.kafka StringKeyValueScheme extends StringScheme. However it doesn't override the method getOutputFields() from StringScheme

public Fields getOutputFields() {
        return new Fields(STRING_SCHEME_KEY);
    }

And this method returns only one field, instead of two (one for key and one for value), which causes problems.
It would be better to override the method getOutputFields() in StringKeyValueScheme with e.g.

    @Override
    public Fields getOutputFields() {
        return new Fields(FieldNameBasedTupleToKafkaMapper.BOLT_KEY, FieldNameBasedTupleToKafkaMapper.BOLT_MESSAGE);
    }

The important thing is, that getOutputFields() should return two fields and not one.

Issue Links

• links to: GitHub Pull Request #1822