Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-1946

ShellBolt.java - On busy system BoltHeartbeatTimerTask fires before setHeartbeat() is executed

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 1.0.2, 1.1.0
    • Component/s: storm-core
    • Labels:

      Description

      When storm stars a large number of ShellBolt-s that consume a lot of CPU time to initialize, it creates a lot of contention between processes for CPU resource. That leads to BoltHeartbeatTimerTask being fired up after 1 second delay before setHeartbeat() assigns initial value to lastHeartbeatTimestamp variable.
      As a result when BoltHeartbeatTimeTask fires up for the first time, getLastHeartbeat() returns value of 0. This in turn leads bolt to die with "subprocess heartbeat timeout" message.
      The fix is to place setHeartBeat() before BoltHeartbeatTimerTask is created. The patch for this is attached.

        Attachments

        1. ShellBolt.java.patch
          1 kB
          Slava Andreyev

          Issue Links

            Activity

              People

              • Assignee:
                slava92 Slava Andreyev
                Reporter:
                slava92 Slava Andreyev
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: