[STORM-1594] org.apache.storm.tuple.Fields can throw NPE if given invalid field in selector

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0, 1.1.0, 1.0.3
• Component/s: storm-core
• Labels: npe
• Assignee: lujinhong
• Reporter: Alessandro Bellina
• Created: 02/Mar/16 06:47
• Updated: 04/Aug/16 16:22
• Resolved: 31/Jul/16 14:41

Description

In class org.apache.storm.tuple.Fields, the select method gets the index of the field to select from the first argument (selector) by using .get. It doesn't set this result to an Integer and check for null (Map.get returns null if the key is not found).

When tuple.get happens, the parameter for tuple.get is an unboxed integer. The null cannot be unboxed to integer, causing an NPE. There is another method in Fields called fieldIndex which will throw an IllegalArgumentException in the case that the field in the selector isn't in the _index.

public List<Object> select(Fields selector, List<Object> tuple) {
    List<Object> ret = new ArrayList<>(selector.size());	
    for(String s: selector) {
        ret.add(tuple.get(_index.get(s)));	
    }
    return ret;
}

Issue Links

• breaks: STORM-2022 FieldsTest.selectingUnknownFieldThrowsTest is failing
• links to: GitHub Pull Request #1522