[STORM-1556] nimbus.clj/wait-for-desired-code-replication wrong reset for current-replication-count-jar in local mode

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0, 2.0.0
• Fix Version/s: 1.0.0, 2.0.0
• Component/s: storm-core
• Assignee: Jark Wu
• Reporter: Jark Wu
• Due: 24/Feb/16
• Created: 17/Feb/16 06:11
• Updated: 22/Mar/16 20:54
• Resolved: 22/Mar/16 20:54

Description

https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/daemon/nimbus.clj#L520-L521

(if (not (ConfigUtils/isLocalMode conf))
    (reset! current-replication-count-conf  (get-blob-replication-count (ConfigUtils/masterStormConfKey storm-id) nimbus)))
(reset! current-replication-count-code  (get-blob-replication-count (ConfigUtils/masterStormCodeKey storm-id) nimbus))
(reset! current-replication-count-jar  (get-blob-replication-count (ConfigUtils/masterStormJarKey storm-id) nimbus))))

We do not go to count the number of jar-replication in local mode, but will count the number of conf-replication. So is it a mistake that current-replication-count-conf and current-replication-count-jar in the wrong place?

If it is a bug, I will create a PR soon.