[STATISTICS-33] Remove the utility function to create an array of samples from a Sampler

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Implemented
• Affects Version/s: 1.0
• Fix Version/s: 1.0
• Component/s: distribution
• Assignee: Unassigned
• Reporter: Alex Herbert
• Created: 22/Jul/21 14:35
• Updated: 06/Dec/22 11:30
• Resolved: 23/Jul/21 17:42

Description

The following utility methods can be removed:

abstract class AbstractDiscreteDistribution {
    public static int[] sample(int n,
                               DiscreteDistribution.Sampler sampler)
}

abstract class AbstractContinuousDistribution {
    public static double[] sample(int n,
                                  ContinuousDistribution.Sampler sampler)
}

They exists as utility methods in a package-private abstract class (thus the public modifier is confusing). I suggest moving them to TestUtils. They can be replicated in code by using a stream:

ContinuousDistribution d = ...;
UniformRandomProvider rng = ...;
int n = 1000;
double[] samples = DoubleStream.stream(d.createSampler(rng)::sample)
                               .limit(n)
                               .toArray();