[STANBOL-903] NLPEngineHelper does not obtain wirte lock when creating an AnalyzedText ContentPart in the initAnalyzedText utility method

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: enhancer-0.10.0
• Component/s: Enhancer
• Assignee: Rupert Westenthaler
• Reporter: Rupert Westenthaler
• Created: 22/Jan/13 11:42
• Updated: 17/Jul/13 15:16
• Resolved: 22/Jan/13 11:55

Description

As the title says the #initAnalyzedText(ContentItem ci) method in the NlpEngineHelper utility (o.a.s.enhancer.nlp module) does not use a write lock when creating the content part.

Using a read lock for checking if the AnalysedText content part exists is fine, but it is not yet created a write lock needs to be obtained to avoid creating multiple AnalysedText content parts.

Users affected by this will notice IllegalStateExceptions with the message that the AnalyzedText content part is already present. Also check that the "NlpEngineHelper#initAnalysedText(...)" is mentioned in the Stacktrace as this Exception may also originate from direct calls to AnalysedTextFactory#createAnalysedText(..)"