[STANBOL-779] EventJobManager may deadlock in case the enhancement job is finished before the calling thread waits

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: enhancer-0.10.0
• Component/s: Enhancer
• Assignee: Rupert Westenthaler
• Reporter: Rupert Westenthaler
• Created: 15/Oct/12 21:43
• Updated: 17/Jul/13 15:16
• Resolved: 14/Dec/12 07:41

Description

Here is the logging of an EnhancementJob that was finished in 11ms - short enough that the notifyAll() was sent before the calling thread was able to wait()

15.10.2012 22:59:50.693 INFO [Enhancement Worker (who,id=2)] org.apache.stanbol.enhancer.jobmanager.event.impl.EnhancementJobHandler Add EnhancementJob:
15.10.2012 22:59:50.693 INFO [Enhancement Worker (who,id=2)] org.apache.stanbol.enhancer.jobmanager.event.impl.EnhancementJobHandler state: processing
15.10.2012 22:59:50.693 INFO [Enhancement Worker (who,id=2)] org.apache.stanbol.enhancer.jobmanager.event.impl.EnhancementJobHandler chain: who_regions
15.10.2012 22:59:50.693 INFO [Enhancement Worker (who,id=2)] org.apache.stanbol.enhancer.jobmanager.event.impl.EnhancementJobHandler content-item: <http://www.kiwi-community.eu/WHO/enhancement/sha1-b1c7561c91af2072ed99c9a4edccca50c1a41513>
15.10.2012 22:59:50.699 INFO [Thread-157] org.apache.stanbol.enhancer.engines.langdetect.LanguageDetectionEnhancementEngine language identified: [en:0.9999961003315406]
15.10.2012 22:59:50.704 INFO [Thread-145] org.apache.stanbol.enhancer.jobmanager.event.impl.EnhancementJobHandler Finished EnhancementJob:
15.10.2012 22:59:50.704 INFO [Thread-145] org.apache.stanbol.enhancer.jobmanager.event.impl.EnhancementJobHandler state: finished
15.10.2012 22:59:50.704 INFO [Thread-145] org.apache.stanbol.enhancer.jobmanager.event.impl.EnhancementJobHandler chain: who_regions
15.10.2012 22:59:50.704 INFO [Thread-145] org.apache.stanbol.enhancer.jobmanager.event.impl.EnhancementJobHandler content-item: <http://www.kiwi-community.eu/WHO/enhancement/sha1-b1c7561c91af2072ed99c9a4edccca50c1a41513>

In those cases the calling thread will miss the expected notify and wait forever.